Skip to content

Makes version selector sticky#2492

Merged
kolchfa-aws merged 3 commits intomainfrom
version-selector-update
Jan 26, 2023
Merged

Makes version selector sticky#2492
kolchfa-aws merged 3 commits intomainfrom
version-selector-update

Conversation

@kolchfa-aws
Copy link
Collaborator

@kolchfa-aws kolchfa-aws commented Jan 24, 2023

Makes version selector sticky

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kolchfa-aws
Makes version selector sticky
19b5e53 
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
@kolchfa-aws kolchfa-aws self-assigned this Jan 24, 2023
@kolchfa-aws
Adds min width to site nav to accommodate version selector
290d399 
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
AMoo-Miki
AMoo-Miki reviewed Jan 25, 2023
View reviewed changes
_sass/custom/custom.scss Outdated
position: sticky;
top: 1rem;
top: 0;
max-height: calc(100vh - 2rem);
Copy link

@AMoo-Miki AMoo-Miki Jan 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need - 2rem now that the top and padding-top are 0?

Copy link
Collaborator Author

@kolchfa-aws kolchfa-aws Jan 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't, thank you for catching this. Updated.

@kolchfa-aws
Makes site nav 100% vh
87d6dca 
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
@kolchfa-aws kolchfa-aws marked this pull request as ready for review January 25, 2023 20:02
@kolchfa-aws kolchfa-aws requested a review from a team as a code owner January 25, 2023 20:02
hdhalter
hdhalter approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@hdhalter hdhalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks, Fanit!

@carolxob carolxob self-requested a review January 26, 2023 16:06
carolxob
carolxob approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@carolxob carolxob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kolchfa-aws kolchfa-aws added backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3 backport 2.4 PR: Backport label for 2.4 backport 2.5 PR: Backport label for 2.5 labels Jan 26, 2023
@kolchfa-aws kolchfa-aws merged commit 84da2cf into main Jan 26, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 26, 2023
@kolchfa-aws @github-actions
Makes version selector sticky (#2492)
7908755 
* Makes version selector sticky

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Adds min width to site nav to accommodate version selector

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Makes site nav 100% vh

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
(cherry picked from commit 84da2cf)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 26, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 26, 2023
@kolchfa-aws @github-actions
Makes version selector sticky (#2492)
a6c9de3 
* Makes version selector sticky

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Adds min width to site nav to accommodate version selector

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Makes site nav 100% vh

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
(cherry picked from commit 84da2cf)
This was referenced Jan 26, 2023
Merged
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 26, 2023
@kolchfa-aws @github-actions
Makes version selector sticky (#2492)
f23b509 
* Makes version selector sticky

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Adds min width to site nav to accommodate version selector

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Makes site nav 100% vh

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
(cherry picked from commit 84da2cf)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 26, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 26, 2023
@kolchfa-aws @github-actions
Makes version selector sticky (#2492)
a7da244 
* Makes version selector sticky

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Adds min width to site nav to accommodate version selector

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Makes site nav 100% vh

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
(cherry picked from commit 84da2cf)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 26, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 26, 2023
@kolchfa-aws @github-actions
Makes version selector sticky (#2492)
dbc0fa8 
* Makes version selector sticky

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Adds min width to site nav to accommodate version selector

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Makes site nav 100% vh

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
(cherry picked from commit 84da2cf)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 26, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 26, 2023
@kolchfa-aws @github-actions
Makes version selector sticky (#2492)
2f9c541 
* Makes version selector sticky

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Adds min width to site nav to accommodate version selector

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Makes site nav 100% vh

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
(cherry picked from commit 84da2cf)
kolchfa-aws added a commit that referenced this pull request Jan 26, 2023
@opensearch-trigger-bot @kolchfa-aws
Makes version selector sticky (#2492) (#2511)
fd630fc 
* Makes version selector sticky

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Adds min width to site nav to accommodate version selector

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Makes site nav 100% vh

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
(cherry picked from commit 84da2cf)

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
kolchfa-aws added a commit that referenced this pull request Jan 26, 2023
@opensearch-trigger-bot @kolchfa-aws
Makes version selector sticky (#2492) (#2510)
57070ff 
* Makes version selector sticky

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Adds min width to site nav to accommodate version selector

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Makes site nav 100% vh

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
(cherry picked from commit 84da2cf)

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
kolchfa-aws added a commit that referenced this pull request Jan 26, 2023
@opensearch-trigger-bot @kolchfa-aws
Makes version selector sticky (#2492) (#2509)
866d0f7 
* Makes version selector sticky

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Adds min width to site nav to accommodate version selector

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Makes site nav 100% vh

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
(cherry picked from commit 84da2cf)

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
kolchfa-aws added a commit that referenced this pull request Jan 26, 2023
@opensearch-trigger-bot @kolchfa-aws
Makes version selector sticky (#2492) (#2508)
f56ee20 
* Makes version selector sticky

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Adds min width to site nav to accommodate version selector

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Makes site nav 100% vh

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
(cherry picked from commit 84da2cf)

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
kolchfa-aws added a commit that referenced this pull request Jan 26, 2023
@opensearch-trigger-bot @kolchfa-aws
Makes version selector sticky (#2492) (#2507)
3558d19 
* Makes version selector sticky

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Adds min width to site nav to accommodate version selector

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Makes site nav 100% vh

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
(cherry picked from commit 84da2cf)

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
kolchfa-aws added a commit that referenced this pull request Jan 26, 2023
@opensearch-trigger-bot @kolchfa-aws
Makes version selector sticky (#2492) (#2506)
577ae64 
* Makes version selector sticky

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Adds min width to site nav to accommodate version selector

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Makes site nav 100% vh

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
(cherry picked from commit 84da2cf)

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
vagimeli pushed a commit that referenced this pull request Jan 26, 2023
@kolchfa-aws @vagimeli
Makes version selector sticky (#2492)
057d418 
* Makes version selector sticky

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Adds min width to site nav to accommodate version selector

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Makes site nav 100% vh

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
vagimeli added a commit that referenced this pull request Jan 30, 2023
@vagimeli
Revert "Makes version selector sticky (#2492)"
e64fe9f 
This reverts commit 057d418.
@Naarcha-AWS Naarcha-AWS deleted the version-selector-update branch March 28, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@AMoo-Miki AMoo-Miki AMoo-Miki left review comments

@hdhalter hdhalter hdhalter approved these changes

@ariamarble ariamarble ariamarble approved these changes

@carolxob carolxob carolxob approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kolchfa-aws kolchfa-aws

Labels

backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3 backport 2.4 PR: Backport label for 2.4 backport 2.5 PR: Backport label for 2.5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kolchfa-aws @AMoo-Miki @hdhalter @ariamarble @carolxob