Skip to content

Scroll to top when last visit was more than 24 hours ago#2457

Merged
kolchfa-aws merged 2 commits intomainfrom
local-storage-update
Jan 26, 2023
Merged

Scroll to top when last visit was more than 24 hours ago#2457
kolchfa-aws merged 2 commits intomainfrom
local-storage-update

Conversation

@kolchfa-aws
Copy link
Collaborator

@kolchfa-aws kolchfa-aws commented Jan 24, 2023

Scroll to top when last visit was more than 24 hours ago

Checklist

  • [ x] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kolchfa-aws
Scroll to top when last visit was more than 24 hours ago
5bf3f99 
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
@kolchfa-aws kolchfa-aws self-assigned this Jan 24, 2023
AMoo-Miki
AMoo-Miki reviewed Jan 25, 2023
View reviewed changes
assets/js/nav-scroll.js Outdated
expiry: currentDate.getTime() + 24 * 60 * 60 * 1000,
}

localStorage.setItem(key, JSON.stringify(scroll));
Copy link

@AMoo-Miki AMoo-Miki Jan 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want this across sessions? IMO it is more appropriate to use sessionStorage for this.

Copy link
Collaborator Author

@kolchfa-aws kolchfa-aws Jan 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to sessionStorage. Thank you!

@kolchfa-aws
Changed localStorage to sessionStorage
1af6bdd 
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
@kolchfa-aws kolchfa-aws marked this pull request as ready for review January 25, 2023 20:16
@kolchfa-aws kolchfa-aws requested a review from a team as a code owner January 25, 2023 20:16
@carolxob carolxob self-requested a review January 26, 2023 16:05
carolxob
carolxob approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@carolxob carolxob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kolchfa-aws kolchfa-aws merged commit 8565bb2 into main Jan 26, 2023
@kolchfa-aws kolchfa-aws added backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3 backport 2.4 PR: Backport label for 2.4 backport 2.5 PR: Backport label for 2.5 labels Jan 26, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 26, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 26, 2023
@kolchfa-aws @github-actions
Scroll to top when last visit was more than 24 hours ago (#2457)
bc77377 
* Scroll to top when last visit was more than 24 hours ago

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Changed localStorage to sessionStorage

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
(cherry picked from commit 8565bb2)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 26, 2023
@kolchfa-aws @github-actions
Scroll to top when last visit was more than 24 hours ago (#2457)
d3fefe8 
* Scroll to top when last visit was more than 24 hours ago

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Changed localStorage to sessionStorage

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
(cherry picked from commit 8565bb2)
This was referenced Jan 26, 2023
Merged
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 26, 2023
@kolchfa-aws @github-actions
Scroll to top when last visit was more than 24 hours ago (#2457)
dfa277a 
* Scroll to top when last visit was more than 24 hours ago

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Changed localStorage to sessionStorage

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
(cherry picked from commit 8565bb2)
This was referenced Jan 26, 2023
Merged
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 26, 2023
@kolchfa-aws @github-actions
Scroll to top when last visit was more than 24 hours ago (#2457)
e1ab25a 
* Scroll to top when last visit was more than 24 hours ago

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Changed localStorage to sessionStorage

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
(cherry picked from commit 8565bb2)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 26, 2023
@kolchfa-aws @github-actions
Scroll to top when last visit was more than 24 hours ago (#2457)
b97b48e 
* Scroll to top when last visit was more than 24 hours ago

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Changed localStorage to sessionStorage

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
(cherry picked from commit 8565bb2)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 26, 2023
@kolchfa-aws @github-actions
Scroll to top when last visit was more than 24 hours ago (#2457)
e97042c 
* Scroll to top when last visit was more than 24 hours ago

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Changed localStorage to sessionStorage

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
(cherry picked from commit 8565bb2)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 26, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 26, 2023
@kolchfa-aws @github-actions
Scroll to top when last visit was more than 24 hours ago (#2457)
0303ad0 
* Scroll to top when last visit was more than 24 hours ago

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Changed localStorage to sessionStorage

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
(cherry picked from commit 8565bb2)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 26, 2023
Merged
kolchfa-aws added a commit that referenced this pull request Jan 26, 2023
@opensearch-trigger-bot @kolchfa-aws
Scroll to top when last visit was more than 24 hours ago (#2457) (#2505)
13dca7e 
* Scroll to top when last visit was more than 24 hours ago

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Changed localStorage to sessionStorage

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
(cherry picked from commit 8565bb2)

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
kolchfa-aws added a commit that referenced this pull request Jan 26, 2023
@opensearch-trigger-bot @kolchfa-aws
Scroll to top when last visit was more than 24 hours ago (#2457) (#2504)
8344d5a 
* Scroll to top when last visit was more than 24 hours ago

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Changed localStorage to sessionStorage

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
(cherry picked from commit 8565bb2)

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
kolchfa-aws added a commit that referenced this pull request Jan 26, 2023
@opensearch-trigger-bot @kolchfa-aws
Scroll to top when last visit was more than 24 hours ago (#2457) (#2503)
4997e38 
* Scroll to top when last visit was more than 24 hours ago

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Changed localStorage to sessionStorage

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
(cherry picked from commit 8565bb2)

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
kolchfa-aws added a commit that referenced this pull request Jan 26, 2023
@opensearch-trigger-bot @kolchfa-aws
Scroll to top when last visit was more than 24 hours ago (#2457) (#2501)
e1d0ed4 
* Scroll to top when last visit was more than 24 hours ago

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Changed localStorage to sessionStorage

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
(cherry picked from commit 8565bb2)

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
kolchfa-aws added a commit that referenced this pull request Jan 26, 2023
@opensearch-trigger-bot @kolchfa-aws
Scroll to top when last visit was more than 24 hours ago (#2457) (#2500)
73de029 
* Scroll to top when last visit was more than 24 hours ago

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Changed localStorage to sessionStorage

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
(cherry picked from commit 8565bb2)

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
kolchfa-aws added a commit that referenced this pull request Jan 26, 2023
@opensearch-trigger-bot @kolchfa-aws
Scroll to top when last visit was more than 24 hours ago (#2457) (#2499)
35216e8 
* Scroll to top when last visit was more than 24 hours ago

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Changed localStorage to sessionStorage

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
(cherry picked from commit 8565bb2)

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
kolchfa-aws added a commit that referenced this pull request Jan 26, 2023
@opensearch-trigger-bot @kolchfa-aws
Scroll to top when last visit was more than 24 hours ago (#2457) (#2502)
dd371fb 
* Scroll to top when last visit was more than 24 hours ago

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Changed localStorage to sessionStorage

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
(cherry picked from commit 8565bb2)

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
vagimeli pushed a commit that referenced this pull request Jan 26, 2023
@kolchfa-aws @vagimeli
Scroll to top when last visit was more than 24 hours ago (#2457)
0a55b3c 
* Scroll to top when last visit was more than 24 hours ago

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

* Changed localStorage to sessionStorage

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
vagimeli added a commit that referenced this pull request Jan 30, 2023
@vagimeli
Revert "Scroll to top when last visit was more than 24 hours ago (#2457…
b71c337 
…)"

This reverts commit 0a55b3c.
@Naarcha-AWS Naarcha-AWS deleted the local-storage-update branch March 28, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@AMoo-Miki AMoo-Miki AMoo-Miki left review comments

@ariamarble ariamarble ariamarble approved these changes

@carolxob carolxob carolxob approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kolchfa-aws kolchfa-aws

Labels

backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3 backport 2.4 PR: Backport label for 2.4 backport 2.5 PR: Backport label for 2.5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kolchfa-aws @AMoo-Miki @ariamarble @carolxob