Skip to content

Update multi-tenancy route to match name change#2064

Merged
cwillum merged 3 commits intoopensearch-project:mainfrom
cwperks:update-tenancy-url
Nov 29, 2022
Merged

Update multi-tenancy route to match name change#2064
cwillum merged 3 commits intoopensearch-project:mainfrom
cwperks:update-tenancy-url

Conversation

@cwperks
Copy link
Member

@cwperks cwperks commented Nov 28, 2022

Signed-off-by: Craig Perkins cwperx@amazon.com

Description

The route to multi-tenancy config was renamed in this PR #1786 and broke existing links elsewhere in the documentation. This PR updates the existing links to account for the name change.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks cwperks requested a review from a team as a code owner November 28, 2022 22:11
@cwperks
Copy link
Member Author

cwperks commented Nov 28, 2022

@cwillum This PR updates broken links to multi-tenancy documentation.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwillum cwillum self-assigned this Nov 29, 2022
@cwillum cwillum added Doc review PR: Doc review in progress backport 2.4 PR: Backport label for 2.4 labels Nov 29, 2022
Copy link
Contributor

@cwillum cwillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested these links locally and they all check out. But we should probably be pointing users to the multi-tenancy index page.

@cwperks These are all appropriate edits. They slipped by me. Thanks. But see comments here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Copy link
Member Author

cwperks commented Nov 29, 2022

@cwperks All links are updated to point to the multi-tenancy index now.

Copy link
Contributor

@cwillum cwillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cwillum cwillum merged commit cb3153d into opensearch-project:main Nov 29, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 29, 2022
* Update multi-tenancy route to match name change

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add slash at end of route

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Link to multi-tenancy index

Signed-off-by: Craig Perkins <cwperx@amazon.com>

Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit cb3153d)
cwillum pushed a commit that referenced this pull request Nov 29, 2022
* Update multi-tenancy route to match name change

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add slash at end of route

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Link to multi-tenancy index

Signed-off-by: Craig Perkins <cwperx@amazon.com>

Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit cb3153d)

Co-authored-by: Craig Perkins <cwperx@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.4 PR: Backport label for 2.4 Doc review PR: Doc review in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants