Skip to content

Add Trace tuning to doc website repo.#1942

Closed
carolxob wants to merge 11 commits intomainfrom
trace-tuning
Closed

Add Trace tuning to doc website repo.#1942
carolxob wants to merge 11 commits intomainfrom
trace-tuning

Conversation

@carolxob
Copy link
Contributor

@carolxob carolxob commented Nov 16, 2022

Signed-off-by: carolxob carolxob@amazon.com

Description

Add Trace tuning to doc website repo.

Issues Addressed

Addresses #1267

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: carolxob <carolxob@amazon.com>
@carolxob carolxob added In progress Issue/PR: The issue or PR is in progress. data-prepper labels Nov 16, 2022
@carolxob carolxob self-assigned this Nov 16, 2022
Signed-off-by: carolxob <carolxob@amazon.com>
@carolxob carolxob marked this pull request as ready for review November 22, 2022 21:32
@carolxob carolxob requested a review from a team as a code owner November 22, 2022 21:32
@carolxob carolxob added Tech review PR: Tech review in progress and removed In progress Issue/PR: The issue or PR is in progress. labels Nov 22, 2022
@carolxob
Copy link
Contributor Author

@dlvenable This PR is ready for tech review.

@carolxob
Copy link
Contributor Author

carolxob commented Dec 6, 2022

@cmanning09 This PR is ready for tech review.

@carolxob
Copy link
Contributor Author

carolxob commented Dec 7, 2022

@arjunnambiartc This is ready for tech review.

@carolxob
Copy link
Contributor Author

@asifsmohammed This is ready for tech review.

Signed-off-by: carolxob <carolxob@amazon.com>
…le and not necessary.

Signed-off-by: carolxob <carolxob@amazon.com>
@carolxob
Copy link
Contributor Author

carolxob commented Jan 3, 2023

@cwillum This is in technical review, but it also needs doc review.

Signed-off-by: carolxob <carolxob@amazon.com>
Signed-off-by: carolxob <carolxob@amazon.com>
Signed-off-by: carolxob <carolxob@amazon.com>
@carolxob carolxob requested a review from ariamarble January 5, 2023 21:01
Copy link
Contributor

@ariamarble ariamarble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than comments

Signed-off-by: carolxob <carolxob@amazon.com>
Signed-off-by: carolxob <carolxob@amazon.com>
@carolxob carolxob requested a review from cwillum January 6, 2023 23:02
Signed-off-by: carolxob <carolxob@amazon.com>
Copy link
Contributor

@cwillum cwillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a couple of comments.

@carolxob
Copy link
Contributor Author

carolxob commented Jan 9, 2023

This page would work best if combined with Trace Analytics.

…lytics.

Signed-off-by: carolxob <carolxob@amazon.com>
@dlvenable
Copy link
Member

This page can be part of #1873, or a sub-page to that page.

@carolxob
Copy link
Contributor Author

Closing this PR because content will be added to #1873.

@carolxob carolxob closed this Jan 12, 2023
@hdhalter hdhalter deleted the trace-tuning branch March 28, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data-prepper Tech review PR: Tech review in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants