Skip to content

Conversation

@karenyrx
Copy link
Contributor

@karenyrx karenyrx commented Nov 9, 2025

Description

The upsert key is supported in the spec for update operations: https://github.com/opensearch-project/opensearch-api-specification/blob/main/spec/schemas/_core.bulk.yaml#L121 , yet is not mentioned in the documentation anywhere.

Specify its usage in the documentation as well.

Issues Resolved

General fix

Version

All

Frontend features

If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link

github-actions bot commented Nov 9, 2025

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

Signed-off-by: Karen X <[email protected]>
Signed-off-by: Karen X <[email protected]>
Signed-off-by: Karen X <[email protected]>
Signed-off-by: Karen X <[email protected]>
@kolchfa-aws kolchfa-aws added In progress Issue/PR: The issue or PR is in progress. backport 3.3 labels Nov 10, 2025
@karenyrx karenyrx marked this pull request as ready for review November 10, 2025 22:10
@karenyrx
Copy link
Contributor Author

hi @kolchfa-aws would you be able to hep take a look at this PR? Thanks!

Signed-off-by: Karen X <[email protected]>
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @karenyrx! Please see my comments and let me know if you have any questions.

@kolchfa-aws kolchfa-aws added Doc review PR: Doc review in progress and removed In progress Issue/PR: The issue or PR is in progress. labels Nov 19, 2025
@kolchfa-aws kolchfa-aws added Editorial review PR: Editorial review in progress and removed Doc review PR: Doc review in progress labels Nov 20, 2025
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natebower natebower removed the Editorial review PR: Editorial review in progress label Nov 20, 2025
@natebower natebower merged commit fc5976c into opensearch-project:main Nov 20, 2025
6 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 20, 2025
* Specify usage of `upsert` key in Bulk operations

Signed-off-by: Karen X <[email protected]>

* update

Signed-off-by: Karen X <[email protected]>

* update 2

Signed-off-by: Karen X <[email protected]>

* Update bulk.md

Signed-off-by: Karen X <[email protected]>

* update scripted upsert too

Signed-off-by: Karen X <[email protected]>

* update scripted upsert

Signed-off-by: Karen X <[email protected]>

* doc_as_upsert

Signed-off-by: Karen X <[email protected]>

* Apply suggestions from code review

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Karen X <[email protected]>

* Tab over code samples so numbered list shows correct numbers

Signed-off-by: kolchfa-aws <[email protected]>

* Tab over code examples in the upsert section

Signed-off-by: kolchfa-aws <[email protected]>

* Update _api-reference/document-apis/bulk.md

Signed-off-by: Nathan Bower <[email protected]>

---------

Signed-off-by: Karen X <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
Signed-off-by: Nathan Bower <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit fc5976c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants