-
Notifications
You must be signed in to change notification settings - Fork 628
Specify usage of upsert key in Bulk operations
#11506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Karen X <[email protected]>
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
Signed-off-by: Karen X <[email protected]>
Signed-off-by: Karen X <[email protected]>
Signed-off-by: Karen X <[email protected]>
Signed-off-by: Karen X <[email protected]>
Signed-off-by: Karen X <[email protected]>
|
hi @kolchfa-aws would you be able to hep take a look at this PR? Thanks! |
Signed-off-by: Karen X <[email protected]>
kolchfa-aws
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @karenyrx! Please see my comments and let me know if you have any questions.
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Karen X <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
Signed-off-by: Nathan Bower <[email protected]>
natebower
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Specify usage of `upsert` key in Bulk operations Signed-off-by: Karen X <[email protected]> * update Signed-off-by: Karen X <[email protected]> * update 2 Signed-off-by: Karen X <[email protected]> * Update bulk.md Signed-off-by: Karen X <[email protected]> * update scripted upsert too Signed-off-by: Karen X <[email protected]> * update scripted upsert Signed-off-by: Karen X <[email protected]> * doc_as_upsert Signed-off-by: Karen X <[email protected]> * Apply suggestions from code review Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Karen X <[email protected]> * Tab over code samples so numbered list shows correct numbers Signed-off-by: kolchfa-aws <[email protected]> * Tab over code examples in the upsert section Signed-off-by: kolchfa-aws <[email protected]> * Update _api-reference/document-apis/bulk.md Signed-off-by: Nathan Bower <[email protected]> --------- Signed-off-by: Karen X <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Signed-off-by: Nathan Bower <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> (cherry picked from commit fc5976c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
The
upsertkey is supported in the spec for update operations: https://github.com/opensearch-project/opensearch-api-specification/blob/main/spec/schemas/_core.bulk.yaml#L121 , yet is not mentioned in the documentation anywhere.Specify its usage in the documentation as well.
Issues Resolved
General fix
Version
All
Frontend features
If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.