Conversation
Update SQL plugin relevance functions documentation. Co-authored-by: MaxKsyunz <maxk@bitquilltech.com> Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
…e into Yury-Fridlyand-main
…page. Make some simple formatting changes Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
kolchfa-aws
reviewed
Sep 11, 2022
kolchfa-aws
reviewed
Sep 11, 2022
kolchfa-aws
reviewed
Sep 11, 2022
kolchfa-aws
reviewed
Sep 11, 2022
kolchfa-aws
reviewed
Sep 11, 2022
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
ariamarble
approved these changes
Sep 19, 2022
Contributor
ariamarble
left a comment
There was a problem hiding this comment.
LGTM, not seeing anything obvious sticking out
cwillum
reviewed
Sep 19, 2022
cwillum
reviewed
Sep 19, 2022
cwillum
approved these changes
Sep 19, 2022
Contributor
cwillum
left a comment
There was a problem hiding this comment.
Just a couple simple comments. Looks great.
natebower
reviewed
Sep 20, 2022
Collaborator
natebower
left a comment
There was a problem hiding this comment.
@kolchfa-aws Please see my comments and let me know if you have any questions. Thanks!
_ml-commons-plugin/index.md
Outdated
| ML Commons for OpenSearch eases the development of machine learning features by providing a set of common machine learning (ML) algorithms through transport and REST API calls. Those calls choose the right nodes and resources for each ML request and monitors ML tasks to ensure uptime. This allows you to leverage existing open-source ML algorithms and reduce the effort required to develop new ML features. | ||
|
|
||
| Interaction with the ML Commons plugin occurs through either the [REST API]({{site.url}}{{site.baseurl}}/ml-commons-plugin/api) or [AD]({{site.url}}{{site.baseurl}}/observability-plugin/ppl/commands#ad) and [kmeans]({{site.url}}{{site.baseurl}}/observability-plugin/ppl/commands#kmeans) Piped Processing Language (PPL) commands. | ||
| Interaction with the ML Commons plugin occurs through either the [REST API]({{site.url}}{{site.baseurl}}/ml-commons-plugin/api) or [AD]({{site.url}}{{site.baseurl}}/search-plugins/sql/ppl/functions#ad) and [kmeans]({{site.url}}{{site.baseurl}}/search-plugins/sql/ppl/functions#kmeans) Piped Processing Language (PPL) commands. |
Collaborator
There was a problem hiding this comment.
If this is the first appearance of "AD", we should define it.
Collaborator
There was a problem hiding this comment.
"AD" is referencing the ad PPL command. I will change to code format.
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 26, 2022
* Merge pull request #1 from Yury-Fridlyand/dev-update-sql-relevance-docs Update SQL plugin relevance functions documentation. Co-authored-by: MaxKsyunz <maxk@bitquilltech.com> Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Address PR feedback. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Address PR feedback by @joshuali925. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Remove PPL page from Observability Plugin. Add link to Observability page. Make some simple formatting changes Signed-off-by: Naarcha-AWS <naarcha@amazon.com> * Reword paragraph Signed-off-by: Naarcha-AWS <naarcha@amazon.com> * Adds SQL and PPL API and other SQL plugin changes Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Formatting changes Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Incorporates editorial comments Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> Signed-off-by: Naarcha-AWS <naarcha@amazon.com> Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Co-authored-by: Yury Fridlyand <yuryf@bitquilltech.com> Co-authored-by: MaxKsyunz <maxk@bitquilltech.com> Co-authored-by: Fanit Kolchina <kolchfa@amazon.com> (cherry picked from commit c69f860)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 26, 2022
* Merge pull request #1 from Yury-Fridlyand/dev-update-sql-relevance-docs Update SQL plugin relevance functions documentation. Co-authored-by: MaxKsyunz <maxk@bitquilltech.com> Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Address PR feedback. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Address PR feedback by @joshuali925. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Remove PPL page from Observability Plugin. Add link to Observability page. Make some simple formatting changes Signed-off-by: Naarcha-AWS <naarcha@amazon.com> * Reword paragraph Signed-off-by: Naarcha-AWS <naarcha@amazon.com> * Adds SQL and PPL API and other SQL plugin changes Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Formatting changes Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Incorporates editorial comments Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> Signed-off-by: Naarcha-AWS <naarcha@amazon.com> Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Co-authored-by: Yury Fridlyand <yuryf@bitquilltech.com> Co-authored-by: MaxKsyunz <maxk@bitquilltech.com> Co-authored-by: Fanit Kolchina <kolchfa@amazon.com> (cherry picked from commit c69f860)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 26, 2022
* Merge pull request #1 from Yury-Fridlyand/dev-update-sql-relevance-docs Update SQL plugin relevance functions documentation. Co-authored-by: MaxKsyunz <maxk@bitquilltech.com> Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Address PR feedback. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Address PR feedback by @joshuali925. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Remove PPL page from Observability Plugin. Add link to Observability page. Make some simple formatting changes Signed-off-by: Naarcha-AWS <naarcha@amazon.com> * Reword paragraph Signed-off-by: Naarcha-AWS <naarcha@amazon.com> * Adds SQL and PPL API and other SQL plugin changes Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Formatting changes Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Incorporates editorial comments Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> Signed-off-by: Naarcha-AWS <naarcha@amazon.com> Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Co-authored-by: Yury Fridlyand <yuryf@bitquilltech.com> Co-authored-by: MaxKsyunz <maxk@bitquilltech.com> Co-authored-by: Fanit Kolchina <kolchfa@amazon.com> (cherry picked from commit c69f860)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 26, 2022
* Merge pull request #1 from Yury-Fridlyand/dev-update-sql-relevance-docs Update SQL plugin relevance functions documentation. Co-authored-by: MaxKsyunz <maxk@bitquilltech.com> Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Address PR feedback. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Address PR feedback by @joshuali925. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Remove PPL page from Observability Plugin. Add link to Observability page. Make some simple formatting changes Signed-off-by: Naarcha-AWS <naarcha@amazon.com> * Reword paragraph Signed-off-by: Naarcha-AWS <naarcha@amazon.com> * Adds SQL and PPL API and other SQL plugin changes Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Formatting changes Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Incorporates editorial comments Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> Signed-off-by: Naarcha-AWS <naarcha@amazon.com> Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Co-authored-by: Yury Fridlyand <yuryf@bitquilltech.com> Co-authored-by: MaxKsyunz <maxk@bitquilltech.com> Co-authored-by: Fanit Kolchina <kolchfa@amazon.com> (cherry picked from commit c69f860)
This was referenced Sep 26, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 26, 2022
* Merge pull request #1 from Yury-Fridlyand/dev-update-sql-relevance-docs Update SQL plugin relevance functions documentation. Co-authored-by: MaxKsyunz <maxk@bitquilltech.com> Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Address PR feedback. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Address PR feedback by @joshuali925. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Remove PPL page from Observability Plugin. Add link to Observability page. Make some simple formatting changes Signed-off-by: Naarcha-AWS <naarcha@amazon.com> * Reword paragraph Signed-off-by: Naarcha-AWS <naarcha@amazon.com> * Adds SQL and PPL API and other SQL plugin changes Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Formatting changes Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Incorporates editorial comments Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> Signed-off-by: Naarcha-AWS <naarcha@amazon.com> Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Co-authored-by: Yury Fridlyand <yuryf@bitquilltech.com> Co-authored-by: MaxKsyunz <maxk@bitquilltech.com> Co-authored-by: Fanit Kolchina <kolchfa@amazon.com> (cherry picked from commit c69f860)
kolchfa-aws
pushed a commit
that referenced
this pull request
Sep 26, 2022
* Merge pull request #1 from Yury-Fridlyand/dev-update-sql-relevance-docs Update SQL plugin relevance functions documentation. Co-authored-by: MaxKsyunz <maxk@bitquilltech.com> Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Address PR feedback. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Address PR feedback by @joshuali925. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Remove PPL page from Observability Plugin. Add link to Observability page. Make some simple formatting changes Signed-off-by: Naarcha-AWS <naarcha@amazon.com> * Reword paragraph Signed-off-by: Naarcha-AWS <naarcha@amazon.com> * Adds SQL and PPL API and other SQL plugin changes Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Formatting changes Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Incorporates editorial comments Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> Signed-off-by: Naarcha-AWS <naarcha@amazon.com> Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Co-authored-by: Yury Fridlyand <yuryf@bitquilltech.com> Co-authored-by: MaxKsyunz <maxk@bitquilltech.com> Co-authored-by: Fanit Kolchina <kolchfa@amazon.com> (cherry picked from commit c69f860) Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Sep 26, 2022
* Merge pull request #1 from Yury-Fridlyand/dev-update-sql-relevance-docs Update SQL plugin relevance functions documentation. Co-authored-by: MaxKsyunz <maxk@bitquilltech.com> Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Address PR feedback. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Address PR feedback by @joshuali925. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Remove PPL page from Observability Plugin. Add link to Observability page. Make some simple formatting changes Signed-off-by: Naarcha-AWS <naarcha@amazon.com> * Reword paragraph Signed-off-by: Naarcha-AWS <naarcha@amazon.com> * Adds SQL and PPL API and other SQL plugin changes Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Formatting changes Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Incorporates editorial comments Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> Signed-off-by: Naarcha-AWS <naarcha@amazon.com> Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Co-authored-by: Yury Fridlyand <yuryf@bitquilltech.com> Co-authored-by: MaxKsyunz <maxk@bitquilltech.com> Co-authored-by: Fanit Kolchina <kolchfa@amazon.com> (cherry picked from commit c69f860) Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Sep 26, 2022
* Merge pull request #1 from Yury-Fridlyand/dev-update-sql-relevance-docs Update SQL plugin relevance functions documentation. Co-authored-by: MaxKsyunz <maxk@bitquilltech.com> Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Address PR feedback. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Address PR feedback by @joshuali925. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Remove PPL page from Observability Plugin. Add link to Observability page. Make some simple formatting changes Signed-off-by: Naarcha-AWS <naarcha@amazon.com> * Reword paragraph Signed-off-by: Naarcha-AWS <naarcha@amazon.com> * Adds SQL and PPL API and other SQL plugin changes Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Formatting changes Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Incorporates editorial comments Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> Signed-off-by: Naarcha-AWS <naarcha@amazon.com> Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Co-authored-by: Yury Fridlyand <yuryf@bitquilltech.com> Co-authored-by: MaxKsyunz <maxk@bitquilltech.com> Co-authored-by: Fanit Kolchina <kolchfa@amazon.com> (cherry picked from commit c69f860) Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Sep 26, 2022
* Merge pull request #1 from Yury-Fridlyand/dev-update-sql-relevance-docs Update SQL plugin relevance functions documentation. Co-authored-by: MaxKsyunz <maxk@bitquilltech.com> Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Address PR feedback. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Address PR feedback by @joshuali925. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Remove PPL page from Observability Plugin. Add link to Observability page. Make some simple formatting changes Signed-off-by: Naarcha-AWS <naarcha@amazon.com> * Reword paragraph Signed-off-by: Naarcha-AWS <naarcha@amazon.com> * Adds SQL and PPL API and other SQL plugin changes Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Formatting changes Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Incorporates editorial comments Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> Signed-off-by: Naarcha-AWS <naarcha@amazon.com> Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Co-authored-by: Yury Fridlyand <yuryf@bitquilltech.com> Co-authored-by: MaxKsyunz <maxk@bitquilltech.com> Co-authored-by: Fanit Kolchina <kolchfa@amazon.com> (cherry picked from commit c69f860) Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Sep 26, 2022
* Merge pull request #1 from Yury-Fridlyand/dev-update-sql-relevance-docs Update SQL plugin relevance functions documentation. Co-authored-by: MaxKsyunz <maxk@bitquilltech.com> Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Address PR feedback. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Address PR feedback by @joshuali925. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Remove PPL page from Observability Plugin. Add link to Observability page. Make some simple formatting changes Signed-off-by: Naarcha-AWS <naarcha@amazon.com> * Reword paragraph Signed-off-by: Naarcha-AWS <naarcha@amazon.com> * Adds SQL and PPL API and other SQL plugin changes Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Formatting changes Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Incorporates editorial comments Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> Signed-off-by: Naarcha-AWS <naarcha@amazon.com> Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Co-authored-by: Yury Fridlyand <yuryf@bitquilltech.com> Co-authored-by: MaxKsyunz <maxk@bitquilltech.com> Co-authored-by: Fanit Kolchina <kolchfa@amazon.com> (cherry picked from commit c69f860) Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Merged
6 tasks
Naarcha-AWS
added a commit
that referenced
this pull request
Oct 6, 2022
* Merge pull request #1 from Yury-Fridlyand/dev-update-sql-relevance-docs Update SQL plugin relevance functions documentation. Co-authored-by: MaxKsyunz <maxk@bitquilltech.com> Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Address PR feedback. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Address PR feedback by @joshuali925. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Remove PPL page from Observability Plugin. Add link to Observability page. Make some simple formatting changes Signed-off-by: Naarcha-AWS <naarcha@amazon.com> * Reword paragraph Signed-off-by: Naarcha-AWS <naarcha@amazon.com> * Adds SQL and PPL API and other SQL plugin changes Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Formatting changes Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Incorporates editorial comments Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> Signed-off-by: Naarcha-AWS <naarcha@amazon.com> Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Co-authored-by: Yury Fridlyand <yuryf@bitquilltech.com> Co-authored-by: MaxKsyunz <maxk@bitquilltech.com> Co-authored-by: Fanit Kolchina <kolchfa@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This makes changes on top of PR #830.
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.