Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the issue of not being able to receive Jaeger HotROD 1.62.0 via OpenTelemetry SDK #4972

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

linghengqian
Copy link
Contributor

@linghengqian linghengqian commented Sep 22, 2024

Description

[Describe what this change achieves]

Additionally you can configure TLS to be enabled but skip verifying the server's certificate chain. This cannot be combined with insecure since insecure won't use TLS at all.
insecure_skip_verify (default = false): whether to skip verifying the certificate or not.

  • The reason why this PR uses otel/opentelemetry-collector-contrib instead of otel/opentelemetry-collector is very simple. https://opentelemetry.io/docs/collector/installation/ does not introduce otel/opentelemetry-collector at all, and that Docker Image does not look like it is for end users.

  • Also see [announcement] logging exporter has been replaced with debug exporter open-telemetry/opentelemetry-collector#11337 . The logging exporter has been removed.

  • otlp/2 is obviously a custom name, I don't understand why it was otlp/2 in the first place. The source seems to be from https://www.youtube.com/watch?v=WhRrwSHDBFs .

  • All opensearch default certificates point to https://node-0.example.com, which limits the customization of the container's hostname. In this case, I think there is no need to share opensearch's /usr/share/opensearch/config/root-ca.pem file with data prepper, and we can directly set insecure: "true".

  • There is no point in mounting /usr/share/data-prepper/config/data-prepper-config.yaml, since all the TLS related parts are turned off.

  • image

  • image

  • image

Issues Resolved

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@linghengqian linghengqian force-pushed the re-example branch 3 times, most recently from 2823b94 to 71b71e5 Compare September 24, 2024 05:35
@linghengqian linghengqian changed the title Fixes the issue of not being able to receive Jaeger HotROD 1.60.0 via OpenTelemetry SDK Fixes the issue of not being able to receive Jaeger HotROD 1.61.0 via OpenTelemetry SDK Sep 24, 2024
@linghengqian linghengqian changed the title Fixes the issue of not being able to receive Jaeger HotROD 1.61.0 via OpenTelemetry SDK Fixes the issue of not being able to receive Jaeger HotROD 1.62.0 via OpenTelemetry SDK Oct 14, 2024
Copy link
Collaborator

@chenqi0805 chenqi0805 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@linghengqian Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removes Jaeger Agent from Jaeger Hotrod Demo
2 participants