Fixes the issue of not being able to receive Jaeger HotROD 1.62.0 via OpenTelemetry SDK #4972
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
jaegertracing/jaeger-agent
to receivejaegertracing/example-hotrod
data, but directly usesotel/opentelemetry-collector-contrib
. According to https://www.jaegertracing.io/docs/1.60/deployment/#agent ,jaegertracing/jaeger-agent
is considered a deprecated component. It does not make any sense.insecure_skip_verify
needs to be configured in the first place.insecure_skip_verify
andinsecure
should not be configured at the same time. See https://github.com/open-telemetry/opentelemetry-collector/blob/v0.109.0/config/configtls/README.md and https://github.com/open-telemetry/opentelemetry-collector/blob/v0.109.0/exporter/otlpexporter/README.md.The reason why this PR uses
otel/opentelemetry-collector-contrib
instead ofotel/opentelemetry-collector
is very simple. https://opentelemetry.io/docs/collector/installation/ does not introduceotel/opentelemetry-collector
at all, and that Docker Image does not look like it is for end users.Also see [announcement] logging exporter has been replaced with debug exporter open-telemetry/opentelemetry-collector#11337 . The logging exporter has been removed.
otlp/2
is obviously a custom name, I don't understand why it wasotlp/2
in the first place. The source seems to be from https://www.youtube.com/watch?v=WhRrwSHDBFs .All opensearch default certificates point to
https://node-0.example.com
, which limits the customization of the container'shostname
. In this case, I think there is no need to share opensearch's/usr/share/opensearch/config/root-ca.pem
file with data prepper, and we can directly setinsecure: "true"
.There is no point in mounting
/usr/share/data-prepper/config/data-prepper-config.yaml
, since all the TLS related parts are turned off.Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.