Skip to content

Resolve tough-cookie to 4.1.3#271

Merged
msfroh merged 1 commit into
opensearch-project:mainfrom
msfroh:resolve-tough-cookie
Sep 5, 2023
Merged

Resolve tough-cookie to 4.1.3#271
msfroh merged 1 commit into
opensearch-project:mainfrom
msfroh:resolve-tough-cookie

Conversation

@msfroh
Copy link
Copy Markdown
Contributor

@msfroh msfroh commented Sep 5, 2023

Based on recommendation by @AMoo-Miki on
opensearch-project/opensearch-build#3856

Description

Regenerating our yarn.lock file, as done by the automation to bump version numbers with each release, downgrades our tough-cookie dependency from 4.1.3 to 2.5, because the version of Cypress that we use depends on 2.5.

To avoid the downgrade, we should update our package.json to reflect the version that we intend to use.

Issues Resolved

N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Based on recommendation by @AMoo-Miki on
opensearch-project/opensearch-build#3856

Signed-off-by: Michael Froh <froh@amazon.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 5, 2023

Codecov Report

Merging #271 (b5366f5) into main (77124d5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #271   +/-   ##
=======================================
  Coverage   86.27%   86.27%           
=======================================
  Files          15       15           
  Lines         204      204           
  Branches       40       40           
=======================================
  Hits          176      176           
  Misses         26       26           
  Partials        2        2           
Flag Coverage Δ
dashboards-search-relevance 86.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@noCharger
Copy link
Copy Markdown
Contributor

I would consider it as a temporary solution; for the long run, we will remove cypress dependency #266.

@msfroh msfroh merged commit 6c0d17c into opensearch-project:main Sep 5, 2023
github-actions Bot added a commit that referenced this pull request Sep 5, 2023
(cherry picked from commit 6c0d17c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
msfroh pushed a commit that referenced this pull request Sep 5, 2023
(cherry picked from commit 6c0d17c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants