[Backport 2.10] [Backport 2.x] Update searchbar snapshots according to upstream changes#119
Merged
pjfitzgibbons merged 2 commits into2.10from Sep 8, 2023
Merged
Conversation
…es (#116) * Update searchbar snapshots according to upstream changes (#115) Signed-off-by: Derek Ho <dxho@amazon.com> (cherry picked from commit 87f51b1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix the test and build workflow file Signed-off-by: Derek Ho <dxho@amazon.com> * change ref from OSD to OS Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Derek Ho <dxho@amazon.com> (cherry picked from commit 35948be) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
approved these changes
Sep 7, 2023
Member
|
@derek-ho If we are planning to merge this in 2.10 will have to update the release notes. |
Signed-off-by: Derek Ho <dxho@amazon.com>
Collaborator
Codecov Report
@@ Coverage Diff @@
## 2.10 #119 +/- ##
=======================================
Coverage ? 62.76%
=======================================
Files ? 10
Lines ? 658
Branches ? 119
=======================================
Hits ? 413
Misses ? 192
Partials ? 53
Flags with carried forward coverage won't be shown. Click here to find out more. 📢 Have feedback on the report? Share it here. |
pjfitzgibbons
approved these changes
Sep 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 35948be from #116.