Add wrap break-all to Noteobook CodeBlock output by pjfitzgibbons · Pull Request #974 · opensearch-project/dashboards-observability

pjfitzgibbons · 2023-09-06T18:32:04Z

Signed-off-by: Peter Fitzgibbons peter.fitzgibbons@gmail.com

Description

Update Notebook Paragraph CSS to ensure wrap-break on all text - even verylongrunonwords.

Issues Resolved

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
[-] New functionality has been documented.
- [-] New functionality has javadoc added
- [-] New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov · 2023-09-06T18:53:45Z

Codecov Report

Merging #974 (a020f17) into main (2930fb2) will decrease coverage by 0.06%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #974      +/-   ##
==========================================
- Coverage   43.97%   43.91%   -0.06%     
==========================================
  Files         313      314       +1     
  Lines       18725    18787      +62     
  Branches     4569     4587      +18     
==========================================
+ Hits         8235     8251      +16     
- Misses      10448    10494      +46     
  Partials       42       42

Flag	Coverage Δ
dashboards-observability	`43.91% <ø> (-0.06%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>

.cypress/integration/2_notebooks.spec.js

public/components/notebooks/components/paragraph_components/__tests__/para_output.test.tsx

.cypress/integration/2_notebooks.spec.js

Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>

* Add wrap break-all to Noteobook CodeBlock output --------- Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> (cherry picked from commit f989783) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Add wrap break-all to Noteobook CodeBlock output --------- Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>

* Add wrap break-all to Noteobook CodeBlock output --------- (cherry picked from commit f989783) Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…roject#985 Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

…orer minor fixes (#1101) * Add documentation linking and validation for query permissions Signed-off-by: Derek Ho <dxho@amazon.com> * Update test with link Signed-off-by: Derek Ho <dxho@amazon.com> * Add form validation for name field Signed-off-by: Derek Ho <dxho@amazon.com> * reverting notebook changes from #974 & #985 Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Remove console log Signed-off-by: Derek Ho <dxho@amazon.com> * surrounding events functionally working Signed-off-by: Paul Sebastian <paulstn@amazon.com> * small surrounding flyout ui changes Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com>

…orer minor fixes (#1101) * Add documentation linking and validation for query permissions Signed-off-by: Derek Ho <dxho@amazon.com> * Update test with link Signed-off-by: Derek Ho <dxho@amazon.com> * Add form validation for name field Signed-off-by: Derek Ho <dxho@amazon.com> * reverting notebook changes from #974 & #985 Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Remove console log Signed-off-by: Derek Ho <dxho@amazon.com> * surrounding events functionally working Signed-off-by: Paul Sebastian <paulstn@amazon.com> * small surrounding flyout ui changes Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> (cherry picked from commit 4a8b500) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…orer minor fixes (#1101) (#1103) * Add documentation linking and validation for query permissions * Update test with link * Add form validation for name field * reverting notebook changes from #974 & #985 * Remove console log * surrounding events functionally working * small surrounding flyout ui changes --------- (cherry picked from commit 4a8b500) Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com>

…orer minor fixes (#1101) (#1102) * Add documentation linking and validation for query permissions * Update test with link * Add form validation for name field * reverting notebook changes from #974 & #985 * Remove console log * surrounding events functionally working * small surrounding flyout ui changes --------- (cherry picked from commit 4a8b500) Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com>

…orer minor fixes (opensearch-project#1101) * Add documentation linking and validation for query permissions Signed-off-by: Derek Ho <dxho@amazon.com> * Update test with link Signed-off-by: Derek Ho <dxho@amazon.com> * Add form validation for name field Signed-off-by: Derek Ho <dxho@amazon.com> * reverting notebook changes from opensearch-project#974 & opensearch-project#985 Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Remove console log Signed-off-by: Derek Ho <dxho@amazon.com> * surrounding events functionally working Signed-off-by: Paul Sebastian <paulstn@amazon.com> * small surrounding flyout ui changes Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com>

) (opensearch-project#1027) * Add wrap break-all to Noteobook CodeBlock output --------- (cherry picked from commit f989783) Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 3684129)

…orer minor fixes (opensearch-project#1101) (opensearch-project#1102) * Add documentation linking and validation for query permissions * Update test with link * Add form validation for name field * reverting notebook changes from opensearch-project#974 & opensearch-project#985 * Remove console log * surrounding events functionally working * small surrounding flyout ui changes --------- (cherry picked from commit 4a8b500) Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> (cherry picked from commit 2d4afc3)

pjfitzgibbons requested review from Swiddis, YANG-DB, anirudha, dai-chen, derek-ho, joshuali925, kavithacm, mengweieric, penghuo, ps48, rupal-bq, seankao-az and vamsimanohar as code owners September 6, 2023 18:32

Add wrap break-all to Noteobook CodeBlock output

cb24fc2

Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>

pjfitzgibbons force-pushed the feature/notebook-output-breakwrap branch from 0f2f2ca to cb24fc2 Compare September 8, 2023 18:22

Swiddis approved these changes Sep 8, 2023

View reviewed changes

ps48 reviewed Sep 8, 2023

View reviewed changes

.cypress/integration/2_notebooks.spec.js Outdated Show resolved Hide resolved

derek-ho reviewed Sep 8, 2023

View reviewed changes

public/components/notebooks/components/paragraph_components/__tests__/para_output.test.tsx Outdated Show resolved Hide resolved

Swiddis reviewed Sep 8, 2023

View reviewed changes

.cypress/integration/2_notebooks.spec.js Outdated Show resolved Hide resolved

Cleanup test files

a020f17

Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>

kavithacm approved these changes Sep 9, 2023

View reviewed changes

pjfitzgibbons merged commit f989783 into main Sep 9, 2023

pjfitzgibbons deleted the feature/notebook-output-breakwrap branch September 9, 2023 11:20

pjfitzgibbons mentioned this pull request Sep 11, 2023

(OUI Next Theme) Observability Notebooks #769

Closed

1 task

pjfitzgibbons added the backport 2.x label Sep 18, 2023

opensearch-trigger-bot bot mentioned this pull request Sep 18, 2023

[Backport 2.x] Add wrap break-all to Noteobook CodeBlock output #1027

Merged

pjfitzgibbons added a commit that referenced this pull request Sep 26, 2023

Add wrap break-all to Noteobook CodeBlock output (#974)

afc1a33

* Add wrap break-all to Noteobook CodeBlock output --------- Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>

pjfitzgibbons added a commit that referenced this pull request Sep 26, 2023

Add wrap break-all to Noteobook CodeBlock output (#974)

34c75df

* Add wrap break-all to Noteobook CodeBlock output --------- Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>

ps48 added a commit to derek-ho/dashboards-observability that referenced this pull request Oct 9, 2023

reverting notebook changes from opensearch-project#974 & opensearch-p…

772e6b4

…roject#985 Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

ps48 mentioned this pull request Oct 9, 2023

Reverting notebooks changes, add docs/validation to datasources, explorer minor fixes #1101

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add wrap break-all to Noteobook CodeBlock output#974

Add wrap break-all to Noteobook CodeBlock output#974
pjfitzgibbons merged 2 commits intomainfrom
feature/notebook-output-breakwrap

pjfitzgibbons commented Sep 6, 2023

Uh oh!

codecov bot commented Sep 6, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

pjfitzgibbons commented Sep 6, 2023

Description

Issues Resolved

Check List

Uh oh!

codecov bot commented Sep 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Sep 6, 2023 •

edited

Loading