Skip to content

added code for the change of design of the sidebar, fixed overriding … #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mengweieric merged 4 commits into from
Sep 5, 2023
Merged

added code for the change of design of the sidebar, fixed overriding … #928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4787fc9
added code for the change of design of the sidebar, fixed overriding …
sumukhswamy Aug 15, 2023
12fb14e
addressed PR comments
sumukhswamy Aug 15, 2023
0a9c3f1
code for overriding pattern
sumukhswamy Aug 15, 2023
5a3ab84
updated snapshots
sumukhswamy Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions public/components/event_analytics/explorer/explorer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,6 +642,7 @@ export const Explorer = ({
isOverridingTimestamp,
query,
isLiveTailOnRef.current,
isOverridingPattern
]);

const visualizations: IVisualizationContainerProps = useMemo(() => {
Expand Down
10 changes: 5 additions & 5 deletions ...c/components/event_analytics/explorer/sidebar/__tests__/__snapshots__/field.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ exports[`Field component Renders a sidebar field 1`] = `
anchorPosition="rightUp"
button={
<FieldButton
className="shard__fieldSelectorField explorer__fieldSelectorField"
className="shard__fieldSelectorField explorer__fieldSelectorField vbFieldButton"
dataTestSubj="field-agent-showDetails"
fieldAction={
<React.Fragment>
Expand Down Expand Up @@ -87,7 +87,7 @@ exports[`Field component Renders a sidebar field 1`] = `
}
isActive={false}
onClick={[Function]}
size="m"
size="s"
/>
}
closePopover={[Function]}
Expand All @@ -105,7 +105,7 @@ exports[`Field component Renders a sidebar field 1`] = `
className="euiPopover__anchor"
>
<FieldButton
className="shard__fieldSelectorField explorer__fieldSelectorField"
className="shard__fieldSelectorField explorer__fieldSelectorField vbFieldButton"
dataTestSubj="field-agent-showDetails"
fieldAction={
<React.Fragment>
Expand Down Expand Up @@ -171,10 +171,10 @@ exports[`Field component Renders a sidebar field 1`] = `
}
isActive={false}
onClick={[Function]}
size="m"
size="s"
>
<div
className="osdFieldButton shard__fieldSelectorField explorer__fieldSelectorField"
className="osdFieldButton osdFieldButton--small shard__fieldSelectorField explorer__fieldSelectorField vbFieldButton"
>
<button
className="osd-resetFocusState osdFieldButton__button"
Expand Down
Loading