update the README.md with Screenshots section#924
Merged
anirudha merged 1 commit intoopensearch-project:mainfrom Aug 19, 2023
Merged
Conversation
Signed-off-by: YANGDB <yang.db.dev@gmail.com>
YANG-DB
requested review from
Swiddis,
anirudha,
dai-chen,
derek-ho,
joshuali925,
kavithacm,
mengweieric,
penghuo,
pjfitzgibbons,
ps48,
rupal-bq,
seankao-az and
vamsimanohar
as code owners
Codecov Report
@@ Coverage Diff @@
## main #924 +/- ##
=======================================
Coverage 43.72% 43.72%
=======================================
Files 313 313
Lines 18629 18629
Branches 4534 4534
=======================================
Hits 8146 8146
Misses 9932 9932
Partials 551 551
Flags with carried forward coverage won't be shown. Click here to find out more. |
Swiddis
approved these changes
Aug 14, 2023
Collaborator
Swiddis
left a comment
Swiddis
left a comment
There was a problem hiding this comment.
Is this the best solution compared to just fixing the embed?
derek-ho
reviewed
Aug 15, 2023
|
|
||
| ## Screenshots | ||
|
|
||
| <video src='https://github.com/opensearch-project/dashboards-observability/assets/48943349/8c918fce-35b8-4824-ae2d-6881aad7b9a2' width=180/> |
Collaborator
There was a problem hiding this comment.
This isn't a screenshot?
Member
Author
There was a problem hiding this comment.
how would u suggest calling it ?
ps48
approved these changes
Aug 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the readme.md file to present screenshots from the dashboard
Issues Resolved
Integration screenshots should be moved down to the screenshots section
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.