Make OSD Bootstrap more sturdy in CI #901
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,6 +14,8 @@ jobs: | |
| strategy: | ||
| matrix: | ||
| os: [ubuntu-latest, windows-latest, macos-latest] | ||
| # Since Windows is inconsistent, we want to let other OSes run on a fail | ||
| fail-fast: false | ||
| runs-on: ${{ matrix.os }} | ||
|
|
||
| steps: | ||
|
|
@@ -51,11 +53,20 @@ jobs: | |
| with: | ||
| path: OpenSearch-Dashboards/plugins/dashboards-observability | ||
|
|
||
| - name: Load Plugin Bootstrap cache | ||
| uses: actions/cache@v3 | ||
| with: | ||
| path: | | ||
| **/node_modules | ||
| **/target | ||
| key: ${{ runner.os }}-bootstrap-${{ hashFiles('OpenSearch-Dashboards/yarn.lock', 'OpenSearch-Dashboards/plugins/dashboards-observability/yarn.lock') }} | ||
| restore-keys: ${{ runner.os }}-bootstrap- | ||
|
|
||
| - name: Plugin Bootstrap | ||
| run: | | ||
| cd OpenSearch-Dashboards | ||
| yarn config set network-timeout 1000000 -g | ||
|
Collaborator
Author
There was a problem hiding this comment. Milliseconds, this PR uses the same number as is used in the OpenSearch Dashboards CI, which in turn is inspired by a related issue on yarn that suggests a similar approach with a number that's also in that ballpark. |
||
| yarn osd bootstrap || yarn osd bootstrap | ||
|
Member
There was a problem hiding this comment. this is ok but there's also a retry workflow https://github.com/marketplace/actions/retry-step |
||
|
|
||
| - name: Test all dashboards-observability modules | ||
| run: | | ||
|
|
@@ -80,4 +91,4 @@ jobs: | |
| uses: actions/upload-artifact@v1 | ||
| with: | ||
| name: dashboards-observability-${{ matrix.os }} | ||
| path: ./OpenSearch-Dashboards/plugins/dashboards-observability/build | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is it caching target?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It showed up when I scanned for what files bootstrap was making, I assumed it may be important. I don't know the technical details of what bootstrap does, so I might have overselected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not sure why bootstrap would touch target. target is the transpiled javascript from source code (public ts/tsx) to be executed in browser,
yarn start(optimizing phase) andyarn buildwould update target.caching it probably won't cause an issue even if your key does not consider source code changes (because
yarn buildwill update target anyways), but i don't think it should be cached. it's not really related to dependencies