[Backport 2.x] Feature/prerelease code cleanup#591
Merged
mengweieric merged 3 commits into2.xfrom Jul 12, 2023
Merged
Conversation
* refactor naming Signed-off-by: Eric Wei <menwe@amazon.com> * refactor vis workspace Signed-off-by: Eric Wei <menwe@amazon.com> * config panel refactoring Signed-off-by: Eric Wei <menwe@amazon.com> * refactor workspace Signed-off-by: Eric Wei <menwe@amazon.com> --------- Signed-off-by: Eric Wei <menwe@amazon.com> (cherry picked from commit 0a803dc)
mengweieric
approved these changes
Jul 5, 2023
Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
Swiddis
approved these changes
Jul 12, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #591 +/- ##
==========================================
- Coverage 43.06% 42.72% -0.35%
==========================================
Files 309 299 -10
Lines 18389 17812 -577
Branches 4450 4363 -87
==========================================
- Hits 7920 7610 -310
+ Misses 10427 10161 -266
+ Partials 42 41 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Eric Wei <menwe@amazon.com>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
* Feature/prerelease code cleanup (opensearch-project#589) * refactor naming Signed-off-by: Eric Wei <menwe@amazon.com> * refactor vis workspace Signed-off-by: Eric Wei <menwe@amazon.com> * config panel refactoring Signed-off-by: Eric Wei <menwe@amazon.com> * refactor workspace Signed-off-by: Eric Wei <menwe@amazon.com> --------- Signed-off-by: Eric Wei <menwe@amazon.com> (cherry picked from commit 0a803dc) * Update test snapshot Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> --------- Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Signed-off-by: Eric Wei <menwe@amazon.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> (cherry picked from commit 82519c8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 0a803dc from #589