Cypress Test fixes for event-analytics by TackAdam · Pull Request #456 · opensearch-project/dashboards-observability

TackAdam · 2023-05-08T17:22:05Z

Description

Fixed the re-naming of event-analytics links causing the testing to fail.
Fixed existing bugs in some of the test so each run successfully

Issues Resolved

[List any issues this PR will resolve]

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

.cypress/integration/1_event_analytics.spec.js

mengweieric · 2023-05-09T15:38:45Z

.cypress/integration/1_event_analytics.spec.js

  });
 });
+
+describe('Saves a query on explorer page', () => {


Why this test was moved?

Order was impacting an error occurring on cypress's side labeled as a "node_modules/async-wait-until/src/waitUntil.js:53:1" putting this test at the end / commenting it out allowed the rest of the test to run successfully.

We may want to know the exact error here to fix it without changing the order.

I want to know why order should matter?

TLDR; The test suite should run in any order. This is imperative.
IF there is a test that is order-dependent, then it is an erroneous test and is high/critical on the list of things-to-fix.

In the course of debugging, this describe() was definitively causing the test-suite to fail.
Moving this test simplified debugging and will simplify fixing it in a subsequent PR.

Signed-off-by: Tackett <tackadam@6cb133a01186.ant.amazon.com>

mengweieric · 2023-05-09T17:10:41Z

package.json

    "@types/react-test-renderer": "^16.9.1",
    "antlr4ts-cli": "^0.5.0-alpha.4",
-    "cypress": "^6.0.0",
+    "cypress": "12.11.0",


Maybe better to upgrade it in a separate PR after we have all-green status for all the tests, and you may also use ^ as it will pick up the latest compatible version

There are some test failures that dont' seem to be fixable in Cypress 6.
Cypress has had significant refactors (6 Majors!). The internal browser-automation has been changed. (Investigating 6 majors worth the code-changes is infeasible).
Some browser-automation techinques from Cypress 6 -> 12.x have changed in ways that are difficult to document. The APIs have changed, which provides a small clue. Other changes are simply observed and trial-and-error + intuition is necessary to determine the "correct" repeatable automation.

should we use consistent cypress version with functional test repo?

mengweieric · 2023-05-09T18:12:44Z

cypress.json

Why cypress.json removed?

Has to be removed in order to run Cypress version 12, replaced with cypress.config.js (Pending commit depending which version we end up using)

Signed-off-by: Tackett <tackadam@6cb133a01186.ant.amazon.com>

Signed-off-by: TackAdam <navytackett@hotmail.com>

TackAdam · 2023-05-11T21:38:37Z

Removed version upgrade as it will be a separate PR pending discussion on #411.
This PR now just fixes the url naming conventions and wait commands.

codecov · 2023-05-11T21:45:27Z

Codecov Report

❗ No coverage uploaded for pull request base (main@0a015f8). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #456   +/-   ##
=======================================
  Coverage        ?   42.82%           
=======================================
  Files           ?      299           
  Lines           ?    17782           
  Branches        ?     4353           
=======================================
  Hits            ?     7616           
  Misses          ?    10125           
  Partials        ?       41

Flag	Coverage Δ
dashboards-observability	`42.82% <0.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: TackAdam <navytackett@hotmail.com>

derek-ho

🚀

kavithacm

LGTM!

* Cypress fixes for EventAnalytics Signed-off-by: Tackett <tackadam@6cb133a01186.ant.amazon.com> * Cypress fixes for EventAnalytics Signed-off-by: Tackett <tackadam@6cb133a01186.ant.amazon.com> * Removed Skip from timestamp, modified config to work for Cypress v12 Signed-off-by: Tackett <tackadam@6cb133a01186.ant.amazon.com> * Removed all waits and replaced with timeouts, per Eric's guidance Signed-off-by: Tackett <tackadam@6cb133a01186.ant.amazon.com> * Added back cypress.json and added ^ to version Signed-off-by: Tackett <tackadam@6cb133a01186.ant.amazon.com> * Added back cypress.json and added ^ to version Signed-off-by: Tackett <tackadam@6cb133a01186.ant.amazon.com> * Removed version upgrade, changed order back Signed-off-by: TackAdam <navytackett@hotmail.com> * Removed version upgrade from package.json Signed-off-by: TackAdam <navytackett@hotmail.com> * Yarn lock regenerated Signed-off-by: TackAdam <navytackett@hotmail.com> * yarn.lock reset to origins file Signed-off-by: TackAdam <navytackett@hotmail.com> * cypress.json reset to origins file Signed-off-by: TackAdam <navytackett@hotmail.com> --------- Signed-off-by: Tackett <tackadam@6cb133a01186.ant.amazon.com> Signed-off-by: TackAdam <navytackett@hotmail.com> Co-authored-by: Tackett <tackadam@6cb133a01186.ant.amazon.com> (cherry picked from commit 2f518c3)

* Cypress fixes for EventAnalytics Signed-off-by: Tackett <tackadam@6cb133a01186.ant.amazon.com> * Cypress fixes for EventAnalytics Signed-off-by: Tackett <tackadam@6cb133a01186.ant.amazon.com> * Removed Skip from timestamp, modified config to work for Cypress v12 Signed-off-by: Tackett <tackadam@6cb133a01186.ant.amazon.com> * Removed all waits and replaced with timeouts, per Eric's guidance Signed-off-by: Tackett <tackadam@6cb133a01186.ant.amazon.com> * Added back cypress.json and added ^ to version Signed-off-by: Tackett <tackadam@6cb133a01186.ant.amazon.com> * Added back cypress.json and added ^ to version Signed-off-by: Tackett <tackadam@6cb133a01186.ant.amazon.com> * Removed version upgrade, changed order back Signed-off-by: TackAdam <navytackett@hotmail.com> * Removed version upgrade from package.json Signed-off-by: TackAdam <navytackett@hotmail.com> * Yarn lock regenerated Signed-off-by: TackAdam <navytackett@hotmail.com> * yarn.lock reset to origins file Signed-off-by: TackAdam <navytackett@hotmail.com> * cypress.json reset to origins file Signed-off-by: TackAdam <navytackett@hotmail.com> --------- Signed-off-by: Tackett <tackadam@6cb133a01186.ant.amazon.com> Signed-off-by: TackAdam <navytackett@hotmail.com> Co-authored-by: Tackett <tackadam@6cb133a01186.ant.amazon.com> (cherry picked from commit 2f518c3) Signed-off-by: TackAdam <navytackett@hotmail.com>

* Cypress fixes for EventAnalytics Signed-off-by: Tackett <tackadam@6cb133a01186.ant.amazon.com> * Cypress fixes for EventAnalytics Signed-off-by: Tackett <tackadam@6cb133a01186.ant.amazon.com> * Removed Skip from timestamp, modified config to work for Cypress v12 Signed-off-by: Tackett <tackadam@6cb133a01186.ant.amazon.com> * Removed all waits and replaced with timeouts, per Eric's guidance Signed-off-by: Tackett <tackadam@6cb133a01186.ant.amazon.com> * Added back cypress.json and added ^ to version Signed-off-by: Tackett <tackadam@6cb133a01186.ant.amazon.com> * Added back cypress.json and added ^ to version Signed-off-by: Tackett <tackadam@6cb133a01186.ant.amazon.com> * Removed version upgrade, changed order back Signed-off-by: TackAdam <navytackett@hotmail.com> * Removed version upgrade from package.json Signed-off-by: TackAdam <navytackett@hotmail.com> * Yarn lock regenerated Signed-off-by: TackAdam <navytackett@hotmail.com> * yarn.lock reset to origins file Signed-off-by: TackAdam <navytackett@hotmail.com> * cypress.json reset to origins file Signed-off-by: TackAdam <navytackett@hotmail.com> --------- Signed-off-by: Tackett <tackadam@6cb133a01186.ant.amazon.com> Signed-off-by: TackAdam <navytackett@hotmail.com> Co-authored-by: Tackett <tackadam@6cb133a01186.ant.amazon.com> (cherry picked from commit 2f518c3) (cherry picked from commit 2b22732)

TackAdam requested review from Swiddis, YANG-DB, dai-chen, derek-ho, joshuali925, kavithacm, mengweieric, penghuo, pjfitzgibbons, ps48, rupal-bq, seankao-az and vamsimanohar as code owners May 8, 2023 17:22

kavithacm reviewed May 8, 2023

View reviewed changes

.cypress/integration/1_event_analytics.spec.js Outdated Show resolved Hide resolved

mengweieric reviewed May 9, 2023

View reviewed changes

Tackett added 3 commits May 9, 2023 09:22

Cypress fixes for EventAnalytics

736f9cc

Signed-off-by: Tackett <tackadam@6cb133a01186.ant.amazon.com>

Cypress fixes for EventAnalytics

f0275f4

Signed-off-by: Tackett <tackadam@6cb133a01186.ant.amazon.com>

Removed Skip from timestamp, modified config to work for Cypress v12

1d76e41

Signed-off-by: Tackett <tackadam@6cb133a01186.ant.amazon.com>

TackAdam force-pushed the main branch from 43f2101 to 1d76e41 Compare May 9, 2023 16:31

Removed all waits and replaced with timeouts, per Eric's guidance

53bc775

Signed-off-by: Tackett <tackadam@6cb133a01186.ant.amazon.com>

mengweieric reviewed May 9, 2023

View reviewed changes

Tackett and others added 5 commits May 9, 2023 11:19

Added back cypress.json and added ^ to version

f21cf8f

Signed-off-by: Tackett <tackadam@6cb133a01186.ant.amazon.com>

Added back cypress.json and added ^ to version

f10707f

Signed-off-by: Tackett <tackadam@6cb133a01186.ant.amazon.com>

Merge branch 'opensearch-project:main' into main

936540c

Removed version upgrade, changed order back

23c5f77

Signed-off-by: TackAdam <navytackett@hotmail.com>

Removed version upgrade from package.json

3022485

Signed-off-by: TackAdam <navytackett@hotmail.com>

Yarn lock regenerated

ae903b9

Signed-off-by: TackAdam <navytackett@hotmail.com>

TackAdam added 2 commits May 12, 2023 09:54

yarn.lock reset to origins file

a05f399

Signed-off-by: TackAdam <navytackett@hotmail.com>

cypress.json reset to origins file

327ea1e

Signed-off-by: TackAdam <navytackett@hotmail.com>

derek-ho approved these changes May 15, 2023

View reviewed changes

kavithacm approved these changes May 15, 2023

View reviewed changes

pjfitzgibbons approved these changes May 15, 2023

View reviewed changes

derek-ho merged commit 2f518c3 into opensearch-project:main May 15, 2023

TackAdam added the backport 2.x label Jul 18, 2023

opensearch-trigger-bot bot mentioned this pull request Jul 18, 2023

[Backport 2.x] Cypress Test fixes for event-analytics #709

Merged

Conversation

TackAdam commented May 8, 2023

Description

Issues Resolved

Check List

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mengweieric May 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TackAdam commented May 11, 2023

Uh oh!

codecov bot commented May 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

derek-ho left a comment

Choose a reason for hiding this comment

Uh oh!

kavithacm left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mengweieric May 9, 2023 •

edited

Loading

codecov bot commented May 11, 2023 •

edited

Loading