Skip to content

Add Error handling on duplicate dashboard names #422

Closed
rupal-bq wants to merge 7 commits intoopensearch-project:2.7from
rupal-bq:name-check
Closed

Add Error handling on duplicate dashboard names #422
rupal-bq wants to merge 7 commits intoopensearch-project:2.7from
rupal-bq:name-check

Conversation

@rupal-bq
Copy link
Copy Markdown
Contributor

Description

  • added check if dashboard with same name already exists

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Peter Fitzgibbons and others added 5 commits April 21, 2023 16:01
* Panel View (legacy)
  - Duplicate
  - Rename

Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com>
Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com>
Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
@rupal-bq
Copy link
Copy Markdown
Contributor Author

depends on #415.

@rupal-bq rupal-bq marked this pull request as ready for review April 25, 2023 17:29
@ps48
Copy link
Copy Markdown
Member

ps48 commented Apr 28, 2023

@rupal-bq Can you please re-base your PR to #435. We added few things on top of #415, in that PR.

});

describe('Testing panels table', () => {
describe.only('Testing panels table', () => {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can remove/revert this file to without .only console and commented out code

@pjfitzgibbons
Copy link
Copy Markdown
Contributor

@rupal-bq #435 (superceded #415) is now merged to 2.7. So just reabase this PR from 2.7 and you'll be ready.

rupal-bq added 2 commits May 2, 2023 18:25
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
@rupal-bq rupal-bq closed this May 2, 2023
@rupal-bq
Copy link
Copy Markdown
Contributor Author

rupal-bq commented May 2, 2023

created #441

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants