Rename Panels => Observability Dashboard#380
Merged
pjfitzgibbons merged 5 commits intomainfrom Apr 18, 2023
Merged
Conversation
Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com>
pjfitzgibbons
requested review from
Swiddis,
YANG-DB,
anirudha,
dai-chen,
derek-ho,
joshuali925,
kavithacm,
mengweieric,
ps48,
rupal-bq and
vamsimanohar
as code owners
ps48
reviewed
Apr 18, 2023
Comment on lines
148
to
151
| // .then((res) => res.operationalPanel) | ||
| // .catch((err) => { | ||
| // console.error('Issue in fetching the operational panel to duplicate', err); | ||
| // console.error('Issue in fetching the Observability Dashboard to duplicate', err); | ||
| // }); |
Member
There was a problem hiding this comment.
Can be removed, if not being used.
Contributor
Author
There was a problem hiding this comment.
Want to keep these until Toast re-imiplementation. THat's where I'll trap thte error handlers correctly.
ps48
reviewed
Apr 18, 2023
Comment on lines
231
to
240
| // // if (renamedCustomPanel) renamedCustomPanel.name = editedCustomPanelName; | ||
| // // return newCustomPanelData; | ||
| // // }); | ||
| // // setToast(`Operational Panel successfully renamed into "${editedCustomPanelName}"`); | ||
| // // setToast(`Observability Dashboard successfully renamed into "${editedCustomPanelName}"`); | ||
| // } catch (err) { | ||
| // console.log( | ||
| // 'Error renaming Operational Panel, please make sure you have the correct permission.', | ||
| // 'Error renaming Observability Dashboard, please make sure you have the correct permission.', | ||
| // 'danger' | ||
| // ); | ||
| // console.error(err.body.message); |
joshuali925
reviewed
Apr 18, 2023
Member
joshuali925
left a comment
joshuali925
left a comment
There was a problem hiding this comment.
i still see some panels, checking if they should also be changed?
Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com>
Panel View SavedObject - Duplicate Action - protect render from invalid record - hide render while loading Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com> Co-authored-by: Peter Fitzgibbons <pjfitz@amazon.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
pjfitzgibbons
pushed a commit
that referenced
this pull request
Apr 18, 2023
* Rename Panels => Observability Dashboard --------- Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com> Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Peter Fitzgibbons <pjfitz@amazon.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit d05f136) Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com>
joshuali925
added a commit
to joshuali925/dashboards-observability
that referenced
this pull request
Apr 18, 2023
* Rename Panels => Observability Dashboard --------- Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com> Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Peter Fitzgibbons <pjfitz@amazon.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rename all references to Observability Dashboard
Includes OSD-core Dashboard registration of Observabiltiy Dashboards to Dashboards / Dashboards List
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.