fix replace in new so panel#367
Merged
derek-ho merged 2 commits intoopensearch-project:mainfrom Apr 17, 2023
Merged
Conversation
Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho
requested review from
Swiddis,
YANG-DB,
anirudha,
dai-chen,
joshuali925,
kavithacm,
mengweieric,
pjfitzgibbons,
ps48,
rupal-bq and
vamsimanohar
as code owners
Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho
commented
Apr 17, 2023
|
|
||
| const updateSavedObjectPanel = (panel: CustomPanelType) => savedObjectPanelsClient.update(panel); | ||
|
|
||
| export const uuidRx = /^[0-9a-fA-F]{8}\b-[0-9a-fA-F]{4}\b-[0-9a-fA-F]{4}\b-[0-9a-fA-F]{4}\b-[0-9a-fA-F]{12}$/; |
Collaborator
Author
There was a problem hiding this comment.
accidentally removed in merge of previous PR
joshuali925
approved these changes
Apr 17, 2023
mengweieric
approved these changes
Apr 17, 2023
ps48
approved these changes
Apr 17, 2023
pjfitzgibbons
pushed a commit
that referenced
this pull request
Apr 17, 2023
* fix replace in new so panel Signed-off-by: Derek Ho <dxho@amazon.com> * remove unecessary imports Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com>
pjfitzgibbons
pushed a commit
that referenced
this pull request
Apr 18, 2023
* fix replace in new so panel Signed-off-by: Derek Ho <dxho@amazon.com> * remove unecessary imports Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> (cherry picked from commit 493c223)
joshuali925
pushed a commit
to joshuali925/dashboards-observability
that referenced
this pull request
Apr 18, 2023
* fix replace in new so panel Signed-off-by: Derek Ho <dxho@amazon.com> * remove unecessary imports Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements replace in new SO panels
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.