Fix saved visualization edit url in visualize#359
Merged
joshuali925 merged 1 commit intoopensearch-project:mainfrom Apr 17, 2023
Merged
Fix saved visualization edit url in visualize#359joshuali925 merged 1 commit intoopensearch-project:mainfrom
joshuali925 merged 1 commit intoopensearch-project:mainfrom
Conversation
joshuali925
requested review from
Swiddis,
YANG-DB,
anirudha,
dai-chen,
derek-ho,
kavithacm,
mengweieric,
pjfitzgibbons,
ps48,
rupal-bq and
vamsimanohar
as code owners
Member
Author
|
looks like something broke CI? tests are failing unrelated to my change |
YANG-DB
approved these changes
Apr 14, 2023
Signed-off-by: Joshua Li <joshuali925@gmail.com>
joshuali925
force-pushed
the
fix-vis-editurl
branch
from
a131b31 to
8c8303c
Compare
6 tasks
ps48
approved these changes
Apr 17, 2023
joshuali925
added a commit
to joshuali925/dashboards-observability
that referenced
this pull request
Apr 17, 2023
Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit 138fbe1)
joshuali925
added a commit
to joshuali925/dashboards-observability
that referenced
this pull request
Apr 17, 2023
Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit 138fbe1)
6 tasks
pjfitzgibbons
pushed a commit
that referenced
this pull request
Apr 17, 2023
Signed-off-by: Joshua Li <joshuali925@gmail.com>
pjfitzgibbons
pushed a commit
that referenced
this pull request
Apr 18, 2023
Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit 138fbe1) Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ID in edit url is missing object type
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.