Left-Nav app registrations for Observability - WIP#350
Merged
pjfitzgibbons merged 13 commits intomainfrom Apr 14, 2023
Merged
Conversation
Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com>
pjfitzgibbons
force-pushed
the
left-nav-cohesion
branch
from
2acaa34 to
9e46292
Compare
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
* Operational Panels Integrate with Dashboards-List --------- Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Eric Wei <menwe@amazon.com> Co-authored-by: Peter Fitzgibbons <pjfitz@amazon.com> Co-authored-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com>
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com>
Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com>
pjfitzgibbons
requested review from
Swiddis,
YANG-DB,
anirudha,
dai-chen,
derek-ho,
joshuali925,
kavithacm,
mengweieric,
ps48,
rupal-bq and
vamsimanohar
as code owners
# Conflicts: # .cypress/integration/3_panels.spec.ts # public/components/app.tsx # public/components/custom_panels/home.tsx # public/plugin.ts
joshuali925
reviewed
Apr 14, 2023
Member
joshuali925
left a comment
joshuali925
left a comment
There was a problem hiding this comment.
i know it's WIP but since we are merging them to main, my question is when do we really review the code change?
Member
There was a problem hiding this comment.
could you remove .DS_Store from git
| @@ -18,24 +18,6 @@ import { | |||
|
|
|||
| import { suppressResizeObserverIssue } from '../utils/constants'; | |||
|
|
|||
| const moveToEventsHome = () => { | |||
Member
There was a problem hiding this comment.
are we using cypress from https://github.com/opensearch-project/opensearch-dashboards-functional-test/ repo or here?
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "baseUrl": "http://localhost:5601", | |||
| "baseUrl": "http://localhost:5602", | |||
derek-ho
added a commit
to derek-ho/dashboards-observability
that referenced
this pull request
Apr 17, 2023
* Left Nav links. Working for Notebook. * Remove observability side bar * Events URL working * Fix metrics link from left nav * Fix applications link --------- Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Eric Wei <menwe@amazon.com> Co-authored-by: Peter Fitzgibbons <pjfitz@amazon.com> Co-authored-by: Rupal Mahajan <maharup@amazon.com> Co-authored-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: Derek Ho <dxho@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com>
joshuali925
pushed a commit
to joshuali925/dashboards-observability
that referenced
this pull request
Apr 18, 2023
…t#350) * Left Nav links. Working for Notebook. * Remove observability side bar * Events URL working * Fix metrics link from left nav * Fix applications link --------- Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Eric Wei <menwe@amazon.com> Co-authored-by: Peter Fitzgibbons <pjfitz@amazon.com> Co-authored-by: Rupal Mahajan <maharup@amazon.com> Co-authored-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: Derek Ho <dxho@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modify Observability plugin registration to make Observability a "top level" grouping on the OSD Left Navigation fly-out.
The P3/P4 result will look like :
Our P1 goal is only the Observability Grouping :
Applications
Logs
Metrics
Traces
Notebooks
Note that Traces does not have an indpendent module at this time.
Also note that "Logs" is our current Event Explorer
The "Observability" link under the "OpenSearch Plugins" group will remain, with it's default page-link as Event Explorer.
Issues Resolved
resolves #34
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.