Skip to content

[Backport 2.x] Add modal for DQL language#1421

Merged
mengweieric merged 1 commit into2.xfrom
backport/backport-1420-to-2.x
Feb 7, 2024
Merged

[Backport 2.x] Add modal for DQL language#1421
mengweieric merged 1 commit into2.xfrom
backport/backport-1420-to-2.x

Conversation

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

Backport 29e1b42 from #1420.

* add modal for DQL

Signed-off-by: Eric <menwe@amazon.com>

* group name renaming

Signed-off-by: Eric <menwe@amazon.com>

* fix linting error

Signed-off-by: Eric <menwe@amazon.com>

* update snapshot

Signed-off-by: Eric <menwe@amazon.com>

---------

Signed-off-by: Eric <menwe@amazon.com>
(cherry picked from commit 29e1b42)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@mengweieric mengweieric added the enhancement New feature or request label Feb 7, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (489bb8c) 54.99% compared to head (06e5064) 55.00%.

Files Patch % Lines
public/components/common/search/search.tsx 52.94% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #1421      +/-   ##
==========================================
+ Coverage   54.99%   55.00%   +0.01%     
==========================================
  Files         315      315              
  Lines       11166    11178      +12     
  Branches     2991     2992       +1     
==========================================
+ Hits         6141     6149       +8     
- Misses       4974     4978       +4     
  Partials       51       51              
Flag Coverage Δ
dashboards-observability 55.00% <52.94%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mengweieric mengweieric merged commit 45f4753 into 2.x Feb 7, 2024
@github-actions github-actions bot deleted the backport/backport-1420-to-2.x branch February 7, 2024 02:20
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
…ect#1421)

* add modal for DQL

* group name renaming

* fix linting error

* update snapshot

---------

(cherry picked from commit 29e1b42)

Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 45f4753)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants