Skip to content

Fix trace link in event viewer#1390

Merged
joshuali925 merged 1 commit intoopensearch-project:mainfrom
st4lk:fix-trace-link
Jan 31, 2024
Merged

Fix trace link in event viewer#1390
joshuali925 merged 1 commit intoopensearch-project:mainfrom
st4lk:fix-trace-link

Conversation

@st4lk
Copy link
Copy Markdown
Contributor

@st4lk st4lk commented Jan 30, 2024

Description

Fix the trace link from event viewer (gif video included):
traces-link

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Alexey Evseev <myhappydo@gmail.com>
@mengweieric mengweieric added backport 2.x bug Something isn't working labels Jan 31, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2ca2c75) 53.87% compared to head (2b5f8f2) 53.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1390   +/-   ##
=======================================
  Coverage   53.87%   53.87%           
=======================================
  Files         316      316           
  Lines       11309    11309           
  Branches     2957     3014   +57     
=======================================
  Hits         6093     6093           
+ Misses       5168     5167    -1     
- Partials       48       49    +1     
Flag Coverage Δ
dashboards-observability 53.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@mengweieric mengweieric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

Copy link
Copy Markdown
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@joshuali925 joshuali925 merged commit 4bffb00 into opensearch-project:main Jan 31, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 31, 2024
Signed-off-by: Alexey Evseev <myhappydo@gmail.com>
(cherry picked from commit 4bffb00)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mengweieric pushed a commit that referenced this pull request Jan 31, 2024
(cherry picked from commit 4bffb00)

Signed-off-by: Alexey Evseev <myhappydo@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
paulstn pushed a commit to paulstn/dashboards-observability that referenced this pull request Feb 1, 2024
Signed-off-by: Alexey Evseev <myhappydo@gmail.com>
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
…project#1396)

(cherry picked from commit 4bffb00)

Signed-off-by: Alexey Evseev <myhappydo@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 7766832)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants