Optimize images in integrations repository#1387
Merged
Swiddis merged 2 commits intoopensearch-project:mainfrom Jan 29, 2024
Merged
Optimize images in integrations repository#1387Swiddis merged 2 commits intoopensearch-project:mainfrom
Swiddis merged 2 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
YANG-DB
approved these changes
Jan 29, 2024
Member
|
@Swiddis can u plz add a correspondent issue in the catalog repository for doing the same image reduction size there ? |
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1387 +/- ##
=======================================
Coverage 53.87% 53.87%
=======================================
Files 316 316
Lines 11309 11309
Branches 2957 2957
=======================================
Hits 6093 6093
Misses 5168 5168
Partials 48 48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-1387-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2ca2c751793c14bd951bf2d5294a75952ff5244e
# Push it to GitHub
git push --set-upstream origin backport/backport-1387-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.xThen, create a pull request where the |
Collaborator
Author
|
Need #1392 to backport |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 31, 2024
* Optimize images in integrations repository Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Update test length threshold after optimization reduced it Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit 2ca2c75) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
paulstn
pushed a commit
to paulstn/dashboards-observability
that referenced
this pull request
Feb 1, 2024
* Optimize images in integrations repository Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Update test length threshold after optimization reduced it Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Compression helps save space when encoding integrations to avoid the size limit for documents. Sample data is the other big asset type, I think a decent solution is to truncate it to e.g. 10 records, until the catalog is able to handle more large-file storage. Image size issues became relevant in #1381
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.