[Backport 2.x] feat: enable data grid in Chatbot (#1341)#1383
Merged
joshuali925 merged 2 commits intoopensearch-project:2.xfrom Jan 25, 2024
Merged
Conversation
* feat: enable data grid in Chatbot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update payload Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: Optimize code Co-authored-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: change to MessageRenderer Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: change to fullWidth Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> (cherry picked from commit 745b4c2)
SuZhou-Joe
requested review from
Swiddis,
YANG-DB,
anirudha,
dai-chen,
derek-ho,
joshuali925,
kavithacm,
mengweieric,
penghuo,
pjfitzgibbons,
ps48,
rupal-bq,
seankao-az and
vamsimanohar
as code owners
6 tasks
joshuali925
approved these changes
Jan 24, 2024
mengweieric
approved these changes
Jan 24, 2024
Member
|
not sure why some snapshots failed |
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1383 +/- ##
==========================================
+ Coverage 53.37% 53.53% +0.15%
==========================================
Files 310 312 +2
Lines 10920 10962 +42
Branches 2865 2879 +14
==========================================
+ Hits 5829 5868 +39
- Misses 5043 5046 +3
Partials 48 48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
Author
My fault that I did not update snapshot in previous PR and others help to update snapshot in seperate PR so this backport PR does not include the snapshot fix change, fixed that. |
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…1341) (opensearch-project#1383) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> (cherry picked from commit b3430d1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: SuZhou-Joe suzhou@amazon.com
Signed-off-by: SuZhou-Joe suzhou@amazon.com
Signed-off-by: SuZhou-Joe suzhou@amazon.com
Co-authored-by: Joshua Li joshuali925@gmail.com
Signed-off-by: SuZhou-Joe suzhou@amazon.com
Signed-off-by: SuZhou-Joe suzhou@amazon.com
Signed-off-by: SuZhou-Joe suzhou@amazon.com
Signed-off-by: SuZhou-Joe suzhou@amazon.com
Signed-off-by: SuZhou-Joe suzhou@amazon.com
Co-authored-by: Joshua Li joshuali925@gmail.com
Co-authored-by: Kavitha Conjeevaram Mohan mohakavi@amazon.com
(cherry picked from commit 745b4c2)
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.