feat: for data grid no need to filter stats by#1382
Merged
joshuali925 merged 2 commits intoopensearch-project:mainfrom Jan 25, 2024
Merged
feat: for data grid no need to filter stats by#1382joshuali925 merged 2 commits intoopensearch-project:mainfrom
joshuali925 merged 2 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe
requested review from
Swiddis,
YANG-DB,
anirudha,
dai-chen,
derek-ho,
joshuali925,
kavithacm,
mengweieric,
paulstn,
penghuo,
pjfitzgibbons,
ps48,
rupal-bq,
seankao-az,
sumukhswamy and
vamsimanohar
as code owners
6 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1382 +/- ##
=======================================
Coverage 53.87% 53.87%
=======================================
Files 316 316
Lines 11309 11309
Branches 2957 2957
=======================================
Hits 6093 6093
Misses 5168 5168
Partials 48 48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joshuali925
approved these changes
Jan 24, 2024
server/parsers/ppl_parser.ts
Outdated
Comment on lines
34
to
37
| const statsPPLs = ppls; | ||
| if (!statsPPLs.length) { | ||
| return []; | ||
| } |
Member
There was a problem hiding this comment.
since we don't need ppl based charts, maybe just remove these
Suggested change
| const statsPPLs = ppls; | |
| if (!statsPPLs.length) { | |
| return []; | |
| } |
and change statsPPLs here to ppls?
Member
Author
There was a problem hiding this comment.
Thanks, done for that.
mengweieric
approved these changes
Jan 24, 2024
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Member
Author
|
Merge and backport to 2.x will be much appreciated. @joshuali925 |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 25, 2024
Signed-off-by: SuZhou-Joe <suzhou@amazon.com> (cherry picked from commit 5144529) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuali925
pushed a commit
that referenced
this pull request
Jan 25, 2024
(cherry picked from commit 5144529) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sejli
pushed a commit
to sejli/dashboards-observability
that referenced
this pull request
Jan 26, 2024
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
paulstn
pushed a commit
to paulstn/dashboards-observability
that referenced
this pull request
Feb 1, 2024
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
RyanL1997
added a commit
to RyanL1997/dashboards-observability
that referenced
this pull request
Apr 18, 2024
Signed-off-by: Ryan Liang <jiallian@amazon.com>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…) (opensearch-project#1385) (cherry picked from commit 5144529) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit e28cb38)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before we filter ppls to make sure it includes
stats byas ppl visualization requires two dimensions to render. However in data grid, one dimension is enough so the filter function is useless.Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.