[Feature] Enable ppl visualization in Chatbot#1304
Merged
joshuali925 merged 6 commits intoopensearch-project:mainfrom Dec 21, 2023
Merged
Conversation
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe
requested review from
Swiddis,
YANG-DB,
anirudha,
dai-chen,
derek-ho,
joshuali925,
kavithacm,
mengweieric,
paulstn,
penghuo,
pjfitzgibbons,
ps48,
rupal-bq,
seankao-az,
sumukhswamy and
vamsimanohar
as code owners
SuZhou-Joe
changed the title
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe
force-pushed
the
feature/enable_ppl_visualization_on_main
branch
from
37c5ec6 to
51ab4aa
Compare
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Member
Author
|
@joshuali925 @anirudha Would you mind taking a look on this PR? |
joshuali925
approved these changes
Dec 18, 2023
| * It will gives an type error when dashboards-assistant is not installed so add a ts-ignore to suppress the error. | ||
| */ | ||
| // @ts-ignore | ||
| export type { AssistantSetup } from "../../dashboards-assistant/public"; |
Member
There was a problem hiding this comment.
also add this to
dashboards-observability/public/types.ts
Lines 23 to 29 in 1f9cc08
assistantDashboards?: AssistantSetup;
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Member
Author
|
One more approval is needed, can anyone help to review please? |
Member
|
maybe @paulstn? could you help to review |
mengweieric
approved these changes
Dec 21, 2023
Member
Author
|
@joshuali925 , could you please add |
6 tasks
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 19, 2024
Signed-off-by: SuZhou-Joe <suzhou@amazon.com> (cherry picked from commit 1110e0c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuali925
pushed a commit
that referenced
this pull request
Jan 23, 2024
(cherry picked from commit 1110e0c) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
RyanL1997
pushed a commit
to RyanL1997/dashboards-observability
that referenced
this pull request
Apr 18, 2024
…roject#1342) The dashboard has references to an old path that does not exist anymore: `plugins/opensearch-security/securityconfig/config.yml`. It was replaced by `config/opensearch-security/config.yml` in this commit: opensearch-project/security@b44d7ea Fix the last occurences of `plugins/opensearch-security/securityconfig`. Signed-off-by: Romain Tartière <romain@blogreen.org> Co-authored-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com> (cherry picked from commit 82c27c7c235a3f075e697d566b6fe3c97f4fdcbd) Co-authored-by: Romain Tartière <romain@blogreen.org> Co-authored-by: Craig Perkins <cwperx@amazon.com>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
… (opensearch-project#1374) (cherry picked from commit 1110e0c) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit d9bd287)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable ppl_visualization with Chatbot.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.