Skip to content

Conversation

@AWSHurneyt
Copy link
Collaborator

Description

Manual backport of PR #584

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (a45dd4d) 72.99% compared to head (30df09f) 72.87%.

Files Patch % Lines
...arch/commons/alerting/model/ClusterMetricsInput.kt 60.60% 9 Missing and 4 partials ⚠️
...lin/org/opensearch/commons/alerting/model/Alert.kt 70.96% 7 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x     #586      +/-   ##
============================================
- Coverage     72.99%   72.87%   -0.13%     
- Complexity      856      863       +7     
============================================
  Files           133      133              
  Lines          5773     5810      +37     
  Branches        707      715       +8     
============================================
+ Hits           4214     4234      +20     
- Misses         1248     1261      +13     
- Partials        311      315       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AWSHurneyt AWSHurneyt merged commit 6a579cd into opensearch-project:2.x Feb 6, 2024
AWSHurneyt added a commit to AWSHurneyt/common-utils that referenced this pull request Apr 12, 2024
…roject#584 (opensearch-project#586)

* Added clusters field to support cross cluster cluster metrics monitors.

Signed-off-by: AWSHurneyt <[email protected]>

* Fixed writeTo.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated tests.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated tests.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants