[Backport 2.x] Fix after core #8157 (#486)#499
Merged
bowenlan-amzn merged 1 commit intoopensearch-project:2.xfrom Jul 22, 2023
Merged
[Backport 2.x] Fix after core #8157 (#486)#499bowenlan-amzn merged 1 commit intoopensearch-project:2.xfrom
bowenlan-amzn merged 1 commit intoopensearch-project:2.xfrom
Conversation
* Fix after core #8157 Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Fix ktlint issue Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Fix spotless java check Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> --------- Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> (cherry picked from commit 003071c) Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
commented
Jul 21, 2023
| isSnapshot = "true" == System.getProperty("build.snapshot", "true") | ||
| buildVersionQualifier = System.getProperty("build.version_qualifier", "") | ||
| kotlin_version = System.getProperty("kotlin.version", "1.6.10") | ||
| kotlin_version = System.getProperty("kotlin.version", "1.8.21") |
Contributor
Author
There was a problem hiding this comment.
@bowenlan-amzn I am not sure we need upgrade this in 2.x branch, can you confirm?
Codecov Report
@@ Coverage Diff @@
## 2.x #499 +/- ##
============================================
+ Coverage 72.82% 72.84% +0.01%
+ Complexity 837 835 -2
============================================
Files 129 129
Lines 5587 5586 -1
Branches 683 683
============================================
Hits 4069 4069
+ Misses 1216 1215 -1
Partials 302 302
|
Contributor
Author
|
@bowenlan-amzn @AWSHurneyt would you mind do the review for this PR? |
AWSHurneyt
approved these changes
Jul 21, 2023
bowenlan-amzn
approved these changes
Jul 22, 2023
AWSHurneyt
pushed a commit
to AWSHurneyt/common-utils
that referenced
this pull request
Apr 12, 2024
* Fix after core #8157 * Fix ktlint issue * Fix spotless java check --------- (cherry picked from commit 003071c) Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 003071c from #486