Skip to content

Adds audit state in Alert#461

Merged
eirsep merged 1 commit intoopensearch-project:mainfrom
eirsep:audit
Jun 21, 2023
Merged

Adds audit state in Alert#461
eirsep merged 1 commit intoopensearch-project:mainfrom
eirsep:audit

Conversation

@eirsep
Copy link
Copy Markdown
Member

@eirsep eirsep commented Jun 21, 2023

Description

Adds audit state in Alert

Alerts are created in audit state when they are generated by delegate monitors of a workflow since chained alerts can be configured and acknowledged, the underlying monitors' alerts are simply for evaluating chained alert triggers and auditing purpose. Audit state alerts will be created in the history index and do not need to be acknowledged by users.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 21, 2023

Codecov Report

Merging #461 (050289b) into main (fcb853e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main     #461   +/-   ##
=========================================
  Coverage     73.80%   73.81%           
  Complexity      824      824           
=========================================
  Files           127      127           
  Lines          5353     5354    +1     
  Branches        675      675           
=========================================
+ Hits           3951     3952    +1     
  Misses         1104     1104           
  Partials        298      298           
Impacted Files Coverage Δ
...lin/org/opensearch/commons/alerting/model/Alert.kt 75.45% <100.00%> (+0.08%) ⬆️

Comment thread src/test/kotlin/org/opensearch/commons/alerting/AlertTests.kt Outdated
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
@eirsep eirsep merged commit f1c0f1d into opensearch-project:main Jun 21, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 21, 2023
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
(cherry picked from commit f1c0f1d)
eirsep added a commit that referenced this pull request Jun 21, 2023
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
(cherry picked from commit f1c0f1d)

Co-authored-by: Surya Sashank Nistala <sashank.nistala@gmail.com>
AWSHurneyt pushed a commit to AWSHurneyt/common-utils that referenced this pull request Apr 12, 2024
…t#462)

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
(cherry picked from commit f1c0f1d)

Co-authored-by: Surya Sashank Nistala <sashank.nistala@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants