acknowledge chained alert request for workflow#459
Merged
eirsep merged 1 commit intoopensearch-project:mainfrom Jun 21, 2023
Merged
acknowledge chained alert request for workflow#459eirsep merged 1 commit intoopensearch-project:mainfrom
eirsep merged 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
eirsep
requested review from
AWSHurneyt,
bowenlan-amzn,
getsaurabh02,
lezzago,
qreshi,
rishabhmaurya,
sbcd90 and
tlfeng
as code owners
Codecov Report
@@ Coverage Diff @@
## main #459 +/- ##
============================================
+ Coverage 73.78% 73.80% +0.02%
- Complexity 819 824 +5
============================================
Files 126 127 +1
Lines 5341 5353 +12
Branches 675 675
============================================
+ Hits 3941 3951 +10
- Misses 1103 1104 +1
- Partials 297 298 +1
|
sbcd90
approved these changes
Jun 21, 2023
lezzago
approved these changes
Jun 21, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 21, 2023
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> (cherry picked from commit fcb853e)
eirsep
added a commit
that referenced
this pull request
Jun 21, 2023
AWSHurneyt
pushed a commit
to AWSHurneyt/common-utils
that referenced
this pull request
Apr 12, 2024
… (opensearch-project#460) Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> (cherry picked from commit fcb853e) Co-authored-by: Surya Sashank Nistala <sashank.nistala@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
adds request dto for acknowledging chained alerts.
Current ack alerts API requires monitor Id.
Chained alerts will not have monitor id and are set with workflow id as routing. We will have a new request body accepting alert ids and workflow id to acknowledge chained alerts.