2.x branch - Publish snapshots to maven via GHA by AWSHurneyt · Pull Request #365 · opensearch-project/common-utils

AWSHurneyt · 2023-02-22T01:57:22Z

Description

Publish snapshots to maven via GHA.
Cherry-picked the changes in the main branch PR #362

Issues Resolved

Tests

Tested locally on my 2.x-based branch.

$ find snapshots | sort   
snapshots
snapshots/org
snapshots/org/opensearch
snapshots/org/opensearch/common-utils
snapshots/org/opensearch/common-utils/2.6.0.0-SNAPSHOT
snapshots/org/opensearch/common-utils/2.6.0.0-SNAPSHOT/common-utils-2.6.0.0-20230222.015350-1-javadoc.jar
snapshots/org/opensearch/common-utils/2.6.0.0-SNAPSHOT/common-utils-2.6.0.0-20230222.015350-1-javadoc.jar.md5
snapshots/org/opensearch/common-utils/2.6.0.0-SNAPSHOT/common-utils-2.6.0.0-20230222.015350-1-javadoc.jar.sha1
snapshots/org/opensearch/common-utils/2.6.0.0-SNAPSHOT/common-utils-2.6.0.0-20230222.015350-1-javadoc.jar.sha256
snapshots/org/opensearch/common-utils/2.6.0.0-SNAPSHOT/common-utils-2.6.0.0-20230222.015350-1-javadoc.jar.sha512
snapshots/org/opensearch/common-utils/2.6.0.0-SNAPSHOT/common-utils-2.6.0.0-20230222.015350-1-sources.jar
snapshots/org/opensearch/common-utils/2.6.0.0-SNAPSHOT/common-utils-2.6.0.0-20230222.015350-1-sources.jar.md5
snapshots/org/opensearch/common-utils/2.6.0.0-SNAPSHOT/common-utils-2.6.0.0-20230222.015350-1-sources.jar.sha1
snapshots/org/opensearch/common-utils/2.6.0.0-SNAPSHOT/common-utils-2.6.0.0-20230222.015350-1-sources.jar.sha256
snapshots/org/opensearch/common-utils/2.6.0.0-SNAPSHOT/common-utils-2.6.0.0-20230222.015350-1-sources.jar.sha512
snapshots/org/opensearch/common-utils/2.6.0.0-SNAPSHOT/common-utils-2.6.0.0-20230222.015350-1.jar
snapshots/org/opensearch/common-utils/2.6.0.0-SNAPSHOT/common-utils-2.6.0.0-20230222.015350-1.jar.md5
snapshots/org/opensearch/common-utils/2.6.0.0-SNAPSHOT/common-utils-2.6.0.0-20230222.015350-1.jar.sha1
snapshots/org/opensearch/common-utils/2.6.0.0-SNAPSHOT/common-utils-2.6.0.0-20230222.015350-1.jar.sha256
snapshots/org/opensearch/common-utils/2.6.0.0-SNAPSHOT/common-utils-2.6.0.0-20230222.015350-1.jar.sha512
snapshots/org/opensearch/common-utils/2.6.0.0-SNAPSHOT/common-utils-2.6.0.0-20230222.015350-1.pom
snapshots/org/opensearch/common-utils/2.6.0.0-SNAPSHOT/common-utils-2.6.0.0-20230222.015350-1.pom.md5
snapshots/org/opensearch/common-utils/2.6.0.0-SNAPSHOT/common-utils-2.6.0.0-20230222.015350-1.pom.sha1
snapshots/org/opensearch/common-utils/2.6.0.0-SNAPSHOT/common-utils-2.6.0.0-20230222.015350-1.pom.sha256
snapshots/org/opensearch/common-utils/2.6.0.0-SNAPSHOT/common-utils-2.6.0.0-20230222.015350-1.pom.sha512
snapshots/org/opensearch/common-utils/2.6.0.0-SNAPSHOT/maven-metadata.xml
snapshots/org/opensearch/common-utils/2.6.0.0-SNAPSHOT/maven-metadata.xml.md5
snapshots/org/opensearch/common-utils/2.6.0.0-SNAPSHOT/maven-metadata.xml.sha1
snapshots/org/opensearch/common-utils/2.6.0.0-SNAPSHOT/maven-metadata.xml.sha256
snapshots/org/opensearch/common-utils/2.6.0.0-SNAPSHOT/maven-metadata.xml.sha512
snapshots/org/opensearch/common-utils/maven-metadata.xml
snapshots/org/opensearch/common-utils/maven-metadata.xml.md5
snapshots/org/opensearch/common-utils/maven-metadata.xml.sha1
snapshots/org/opensearch/common-utils/maven-metadata.xml.sha256
snapshots/org/opensearch/common-utils/maven-metadata.xml.sha512

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

gaiksaya · 2023-02-22T03:24:27Z

Hey @AWSHurneyt ,

Posting the same query here. The current snapshots do not include javadoc and sources jar
https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/common-utils/2.6.0.0-SNAPSHOT/
Can you check why the above is doing the same? Maybe gradle task is the issue?

gaiksaya · 2023-02-22T03:32:13Z

Okay this is the culprit https://github.com/opensearch-project/common-utils/pull/365/files#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7R183-R184

I dont know how much this matters. @prudhvigodithi maybe you have an idea?

prudhvigodithi · 2023-02-22T16:01:57Z

Hey @gaiksaya not all projects do publish javadoc and sourcejar, its just the app jar sometimes all what is required, so its upto the team to publish the javadoc and sourcejar.
Thank you

gaiksaya · 2023-02-22T17:23:24Z

I saw this https://github.com/opensearch-project/common-utils/blob/main/scripts/build.sh#L68 maybe what what we want to do?

./gradlew publishShadowPublicationToSnapshotsRepository

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.4.2/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 2s
5 actionable tasks: 2 executed, 3 up-to-date

~/opensearch-project/common-utils   2.x ±  tree snapshots
snapshots
└── org
    └── opensearch
        └── common-utils
            ├── 2.6.0.0-SNAPSHOT
            │   ├── common-utils-2.6.0.0-20230222.174709-1.jar
            │   ├── common-utils-2.6.0.0-20230222.174709-1.jar.md5
            │   ├── common-utils-2.6.0.0-20230222.174709-1.jar.sha1
            │   ├── common-utils-2.6.0.0-20230222.174709-1.jar.sha256
            │   ├── common-utils-2.6.0.0-20230222.174709-1.jar.sha512
            │   ├── common-utils-2.6.0.0-20230222.174709-1.pom
            │   ├── common-utils-2.6.0.0-20230222.174709-1.pom.md5
            │   ├── common-utils-2.6.0.0-20230222.174709-1.pom.sha1
            │   ├── common-utils-2.6.0.0-20230222.174709-1.pom.sha256
            │   ├── common-utils-2.6.0.0-20230222.174709-1.pom.sha512
            │   ├── maven-metadata.xml
            │   ├── maven-metadata.xml.md5
            │   ├── maven-metadata.xml.sha1
            │   ├── maven-metadata.xml.sha256
            │   └── maven-metadata.xml.sha512
            ├── maven-metadata.xml
            ├── maven-metadata.xml.md5
            ├── maven-metadata.xml.sha1
            ├── maven-metadata.xml.sha256
            └── maven-metadata.xml.sha512

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

gaiksaya · 2023-02-22T18:09:05Z

Added the secret

* Publish snapshots to maven via GHA Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * fix task name Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Adjusted maven function used by workflow. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Co-authored-by: Ashish Agrawal <ashisagr@amazon.com> (cherry picked from commit 5b9de98)

* Publish snapshots to maven via GHA Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * fix task name Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Adjusted maven function used by workflow. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Co-authored-by: Ashish Agrawal <ashisagr@amazon.com> (cherry picked from commit 5b9de98) Co-authored-by: AWSHurneyt <hurneyt@amazon.com>

…) (opensearch-project#370) * Publish snapshots to maven via GHA Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * fix task name Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Adjusted maven function used by workflow. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Co-authored-by: Ashish Agrawal <ashisagr@amazon.com> (cherry picked from commit 5b9de98) Co-authored-by: AWSHurneyt <hurneyt@amazon.com>

* Publish snapshots to maven via GHA Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * fix task name Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Adjusted maven function used by workflow. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Co-authored-by: Ashish Agrawal <ashisagr@amazon.com> (cherry picked from commit 5b9de98)

* Publish snapshots to maven via GHA Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * fix task name Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Adjusted maven function used by workflow. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Co-authored-by: Ashish Agrawal <ashisagr@amazon.com> (cherry picked from commit 5b9de98) Co-authored-by: AWSHurneyt <hurneyt@amazon.com>

* Publish snapshots to maven via GHA Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * fix task name Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Adjusted maven function used by workflow. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Co-authored-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

lezzago added 2 commits February 21, 2023 17:49

Publish snapshots to maven via GHA

7cc6ba5

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

fix task name

2aa1d17

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

AWSHurneyt requested a review from gaiksaya February 22, 2023 01:57

AWSHurneyt mentioned this pull request Feb 22, 2023

Publish snapshots to maven via GHA #362

Merged

5 tasks

AWSHurneyt marked this pull request as ready for review February 22, 2023 02:02

AWSHurneyt requested a review from a team February 22, 2023 02:02

sbcd90 previously approved these changes Feb 22, 2023

View reviewed changes

AWSHurneyt added the backport 2.6 label Feb 22, 2023

gaiksaya reviewed Feb 22, 2023

View reviewed changes

Comment thread .github/workflows/maven-publish.yml Outdated

Adjusted maven function used by workflow.

14ad5ff

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

AWSHurneyt dismissed sbcd90’s stale review via 14ad5ff February 22, 2023 17:57

gaiksaya approved these changes Feb 22, 2023

View reviewed changes

Angie-Zhang approved these changes Feb 22, 2023

View reviewed changes

Angie-Zhang merged commit 5b9de98 into opensearch-project:2.x Feb 22, 2023

opensearch-trigger-bot bot mentioned this pull request Feb 22, 2023

[Backport 2.6] 2.x branch - Publish snapshots to maven via GHA #370

Merged

lezzago added the backport 2.5 label Jun 1, 2023

opensearch-trigger-bot bot mentioned this pull request Jun 1, 2023

[Backport 2.5] 2.x branch - Publish snapshots to maven via GHA #443

Merged

lezzago added backport 2.0 backport 2.1 backport 2.2 backport 2.3 labels Jun 12, 2023

lezzago added the backport 2.4 label Jun 12, 2023

This was referenced Jun 12, 2023

[Backport 2.0] 2.x branch - Publish snapshots to maven via GHA #448

Merged

[Backport 2.4] 2.x branch - Publish snapshots to maven via GHA #449

Merged

opensearch-trigger-bot bot mentioned this pull request Jun 12, 2023

[Backport 2.1] 2.x branch - Publish snapshots to maven via GHA #450

Merged

This was referenced Jun 12, 2023

[Backport 2.2] 2.x branch - Publish snapshots to maven via GHA #452

Merged

[Backport 2.3] 2.x branch - Publish snapshots to maven via GHA #451

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

2.x branch - Publish snapshots to maven via GHA#365

2.x branch - Publish snapshots to maven via GHA#365
Angie-Zhang merged 3 commits intoopensearch-project:2.xfrom
AWSHurneyt:2.x_maven_publish

AWSHurneyt commented Feb 22, 2023

Uh oh!

gaiksaya commented Feb 22, 2023

Uh oh!

gaiksaya commented Feb 22, 2023 •

edited

Loading

Uh oh!

prudhvigodithi commented Feb 22, 2023

Uh oh!

gaiksaya commented Feb 22, 2023 •

edited

Loading

Uh oh!

Uh oh!

gaiksaya commented Feb 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

AWSHurneyt commented Feb 22, 2023

Description

Issues Resolved

Tests

Check List

Uh oh!

gaiksaya commented Feb 22, 2023

Uh oh!

gaiksaya commented Feb 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

prudhvigodithi commented Feb 22, 2023

Uh oh!

gaiksaya commented Feb 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

gaiksaya commented Feb 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

gaiksaya commented Feb 22, 2023 •

edited

Loading

gaiksaya commented Feb 22, 2023 •

edited

Loading