Addressing 'org.apache.hc.core5.http.ParseException: Invalid protocol version' under JDK 16+#287
Merged
lezzago merged 1 commit intoopensearch-project:mainfrom Jan 20, 2023
Conversation
Codecov Report
@@ Coverage Diff @@
## main #287 +/- ##
============================================
+ Coverage 71.52% 71.60% +0.08%
- Complexity 666 667 +1
============================================
Files 108 108
Lines 4477 4494 +17
Branches 605 605
============================================
+ Hits 3202 3218 +16
- Misses 1024 1025 +1
Partials 251 251
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
reta
force-pushed
the
fix.jdk.17.tls.factory
branch
from
6797c20 to
5c1d269
Compare
Contributor
Author
|
@dblock could you please check this one out? |
… version' under JDK 16+ Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta
force-pushed
the
fix.jdk.17.tls.factory
branch
from
5c1d269 to
412d287
Compare
3 tasks
Member
|
Sorry for the delay, just noticing this. Why didn't CI run here? |
Contributor
Author
Hm .. not sure to be fair, the run has to be approved for sure |
Member
|
I have admin rights on the org and yet I don't see any approval button ... let me force push something here. |
Closed
Member
|
Looks like CI kicked in now 🤷 |
dblock
approved these changes
Jan 18, 2023
Contributor
Author
Thanks a lot @dblock ! |
lezzago
approved these changes
Jan 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Redko andriy.redko@aiven.io
Description
When using JDK 16+, the
org.apache.hc.core5.http.ParseException: Invalid protocol versionis being thrown.Issues Resolved
See please https://issues.apache.org/jira/browse/HTTPCLIENT-2219
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.