Bug fixes and unit tests#177
Merged
kaituo merged 1 commit intoopensearch-project:mainfrom Aug 19, 2021
Merged
Conversation
First, this PR adds an empty string check in PriorityCache. Second, in EntityColdStarter, this PR clears samples after using them for training. Third, this PR removes unused fields and local variables in ModelManager and BulkUtil. Fourth, this PR decreases the concurrent preview from 5 to 2, with a conservative purpose to reduce potential GC. Fifth, this PR finishes unit tests owed due to my previous PRs. 99% code of the PR is about tests. Testing done: 1. Added unit tests. 2. made sure the basic e2e workflow still works.
Codecov Report
@@ Coverage Diff @@
## main #177 +/- ##
============================================
+ Coverage 67.66% 70.12% +2.46%
- Complexity 2885 2995 +110
============================================
Files 270 270
Lines 14104 14088 -16
Branches 1418 1414 -4
============================================
+ Hits 9543 9879 +336
+ Misses 3973 3590 -383
- Partials 588 619 +31
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ohltyler
approved these changes
Aug 19, 2021
ylwu-amzn
approved these changes
Aug 19, 2021
ohltyler
pushed a commit
to ohltyler/anomaly-detection-2
that referenced
this pull request
Sep 1, 2021
First, this PR adds an empty string check in PriorityCache. Second, in EntityColdStarter, this PR clears samples after using them for training. Third, this PR removes unused fields and local variables in ModelManager and BulkUtil. Fourth, this PR decreases the concurrent preview from 5 to 2, with a conservative purpose to reduce potential GC. Fifth, this PR finishes unit tests owed due to my previous PRs. 99% code of the PR is about tests. Testing done: 1. Added unit tests. 2. made sure the basic e2e workflow still works.
ohltyler
pushed a commit
to ohltyler/anomaly-detection-2
that referenced
this pull request
Sep 1, 2021
First, this PR adds an empty string check in PriorityCache. Second, in EntityColdStarter, this PR clears samples after using them for training. Third, this PR removes unused fields and local variables in ModelManager and BulkUtil. Fourth, this PR decreases the concurrent preview from 5 to 2, with a conservative purpose to reduce potential GC. Fifth, this PR finishes unit tests owed due to my previous PRs. 99% code of the PR is about tests. Testing done: 1. Added unit tests. 2. made sure the basic e2e workflow still works.
ohltyler
pushed a commit
that referenced
this pull request
Sep 1, 2021
First, this PR adds an empty string check in PriorityCache. Second, in EntityColdStarter, this PR clears samples after using them for training. Third, this PR removes unused fields and local variables in ModelManager and BulkUtil. Fourth, this PR decreases the concurrent preview from 5 to 2, with a conservative purpose to reduce potential GC. Fifth, this PR finishes unit tests owed due to my previous PRs. 99% code of the PR is about tests. Testing done: 1. Added unit tests. 2. made sure the basic e2e workflow still works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
First, this PR adds an empty string check in PriorityCache.
Second, in EntityColdStarter, this PR clears samples after using them for training.
Third, this PR removes unused fields and local variables in ModelManager and BulkUtil.
Fourth, this PR decreases the concurrent preview from 5 to 2, with a conservative purpose to reduce potential GC.
Fifth, this PR finishes unit tests owed due to my previous PRs. 99% code of the PR is about tests.
Testing done:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.