Skip to content

Fix MultiEntityResultTests.testQueryErrorEndRunNotNow after log4j upgrade to 2.25.3 #1638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cwperks wants to merge 1 commit into from
Closed

Fix MultiEntityResultTests.testQueryErrorEndRunNotNow after log4j upgrade to 2.25.3 #1638

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/test/java/org/opensearch/ad/transport/MultiEntityResultTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,14 +535,14 @@ public void testQueryErrorEndRunNotNow() throws InterruptedException, IOExceptio
// make PageIterator.next return failure
doAnswer(invocation -> {
ActionListener<SearchResponse> listener = invocation.getArgument(1);
listener
.onFailure(
new SearchPhaseExecutionException(
"search",
allShardsFailedMsg,
new ShardSearchFailure[] { new ShardSearchFailure(new IllegalArgumentException("blah")) }
)
);
// Create SearchPhaseExecutionException without ShardSearchFailure to avoid log4j NPE
// when rendering corrupted stack trace metadata in nested exceptions
SearchPhaseExecutionException ex = new SearchPhaseExecutionException(
"search",
allShardsFailedMsg + "; shardFailures {IllegalArgumentException[blah]}",
new ShardSearchFailure[0]
);
listener.onFailure(ex);
inProgressLatch.countDown();
return null;
}).when(client).search(any(), any());
Expand Down
Loading