Cypress workflow improvements

[ohltyler]

Description

This PR has 2 improvements:

1. Update glob to include subdirectories. Test specs have been added under vis_augmenter subdirectory as part of this PR and are currently not running in this workflow.
2. Remove env vars to just fetch the same branch that the workflow is running from. For example, in main, this will fetch main branches of all the repos. This follows what is done in OSD repo. It also helps prevent conflicts and lessens the differences between main/2.x.

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[ohltyler]

CI will fail to run 3.0 cluster. Confirmed on my local this runs all 11 test suites (8 existing + 3 new under vis_augmenter)

ohltyler@b0f1d86ddbb0 opensearch-dashboards-functional-test % yarn cypress:run-without-security --spec 'cypress/integration/plugins/anomaly-detection-dashboards-plugin/**/*'
yarn run v1.22.19
$ env TZ=America/Los_Angeles NO_COLOR=1 cypress run --headless --env SECURITY_ENABLED=false --spec 'cypress/integration/plugins/anomaly-detection-dashboards-plugin/**/*'
Couldn't determine Mocha version

====================================================================================================

  (Run Starting)

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Cypress:        9.5.4                                                                          │
  │ Browser:        Electron 94 (headless)                                                         │
  │ Node Version:   v14.20.0 (/Users/ohltyler/.nvm/versions/node/v14.20.0/bin/node)                │
  │ Specs:          11 found (plugins/anomaly-detection-dashboards-plugin/create_detector_spec.js, │
  │                  plugins/anomaly-detection-dashboards-plugin/dashboard_spec.js, plugins/anomal │
  │                 y-detection-dashboards-plugin/detector_configuration_spec.js, plugins/anomaly- │
  │                 detection-dashboards-pl...)                                                    │
  │ Searched:       cypress/integration/plugins/anomaly-detection-dashboards-plugin/**/*           │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘

[codecov]

Codecov Report

Merging #560 (d94c675) into main (3863e46) will not change coverage.
The diff coverage is n/a.

❗ Current head d94c675 differs from pull request most recent head 7b77d52. Consider uploading reports for the commit 7b77d52 to get more accurate results

@@           Coverage Diff           @@
##             main     #560   +/-   ##
=======================================
  Coverage   50.25%   50.25%           
=======================================
  Files         166      166           
  Lines        5593     5593           
  Branches     1055     1055           
=======================================
  Hits         2811     2811           
  Misses       2511     2511           
  Partials      271      271           

[kaituo]

Will this skip existing specs like create_detector_spec.js as you only execute specs under anomaly-detection-dashboards-plugin's subdirectories?

[ohltyler]

No, they will be included along with any subdirectories - you can see that in the list of found specs in comment above

[kaituo]

Your command in the comment has no .js:

yarn cypress:run-without-security --spec 'cypress/integration/plugins/anomaly-detection-dashboards-plugin/**/*

[ohltyler]

Confirmed it still shows 11 w/ command:

  │ Specs:          11 found (plugins/anomaly-detection-dashboards-plugin/create_detector_spec.js, │
  │                  plugins/anomaly-detection-dashboards-plugin/dashboard_spec.js, plugins/anomal │
  │                 y-detection-dashboards-plugin/detector_configuration_spec.js, plugins/anomaly- │
  │                 detection-dashboards-pl...)   

[ohltyler]

@amitgalitz can you look into the test failures? Looks related to associated detectors page.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-560-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 53677c54a8df8e2e77a5cb34f98acd5e7c202ab9
# Push it to GitHub
git push --set-upstream origin backport/backport-560-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-560-to-2.x.