Skip to content

[Feature Anywhere] Change to anomaly start time; add test ids #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ohltyler merged 1 commit into from
Jul 3, 2023
Merged

[Feature Anywhere] Change to anomaly start time; add test ids #522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ponents/FeatureAnywhereContextMenu/AssociatedDetectors/containers/AssociatedDetectors.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,7 @@ function AssociatedDetectors({ embeddable, closeFlyout, setMode }) {
<EuiFlexItem grow={false}>
<div>
<EuiButton
data-test-subj="associateDetectorButton"
fill
iconType="link"
onClick={() => {
Expand Down
8 changes: 4 additions & 4 deletions public/components/FeatureAnywhereContextMenu/CreateAnomalyDetector/AddAnomalyDetector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,7 @@ function AddAnomalyDetector({
<EuiSpacer size="m" />

<EnhancedAccordion
id="detectorDetails"
id="detectorDetailsAccordion"
title={detectorNameFromVis}
isOpen={accordionsOpen.detectorDetails}
onToggle={() => onAccordionToggle('detectorDetails')}
Expand Down Expand Up @@ -671,7 +671,7 @@ function AddAnomalyDetector({
<EuiSpacer size="m" />

<EnhancedAccordion
id="advancedConfiguration"
id="advancedConfigurationAccordion"
title="Advanced configuration"
isOpen={accordionsOpen.advancedConfiguration}
onToggle={() =>
Expand Down Expand Up @@ -824,7 +824,7 @@ function AddAnomalyDetector({
<EuiSpacer size="m" />

<EnhancedAccordion
id="modelFeatures"
id="modelFeaturesAccordion"
title="Features"
isOpen={accordionsOpen.modelFeatures}
onToggle={() => onAccordionToggle('modelFeatures')}
Expand Down Expand Up @@ -896,7 +896,7 @@ function AddAnomalyDetector({
{mode === FLYOUT_MODES.existing ? (
<EuiButton
fill={true}
data-test-subj="adAnywhereCreateDetectorButton"
data-test-subj="adAnywhereAssociateDetectorButton"
isLoading={formikProps.isSubmitting}
onClick={() => handleAssociate(selectedDetector)}
>
Expand Down
1 change: 1 addition & 0 deletions public/components/FeatureAnywhereContextMenu/EnhancedAccordion/EnhancedAccordion.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ const EnhancedAccordion = ({
buttonContent={
<div className="enhanced-accordion__title">
<EuiTitle
data-test-subj="accordionTitleButton"
size="s"
onClick={onToggle}
role="button"
Expand Down
2 changes: 1 addition & 1 deletion public/expressions/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export const convertAnomaliesToPointInTimeEventsVisLayer = (
): PointInTimeEventsVisLayer => {
const events = anomalies.map((anomaly: AnomalyData) => {
return {
timestamp: anomaly.startTime + (anomaly.endTime - anomaly.startTime) / 2,
timestamp: anomaly.startTime,
metadata: {},
};
});
Expand Down
1 change: 1 addition & 0 deletions public/pages/DetectorConfig/containers/Features.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,7 @@ export const Features = (props: FeaturesProps) => {
titleSize="s"
>
<EuiBasicTable
data-test-subj="featureTable"
items={sortedItems}
columns={columns}
cellProps={getCellProps}
Expand Down