Skip to content

Fixing visualization eligibility #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amitgalitz merged 1 commit into from
Jun 29, 2023
Merged

Fixing visualization eligibility #519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion public/action/ad_dashboard_action.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import { isReferenceOrValueEmbeddable } from '../../../../src/plugins/embeddable
import { EuiIconType } from '@elastic/eui/src/components/icon/icon';
import { VisualizeEmbeddable } from '../../../../src/plugins/visualizations/public';
import { isEligibleForVisLayers } from '../../../../src/plugins/vis_augmenter/public';
import { getUISettings } from '../services';

export const ACTION_AD = 'ad';

Expand Down Expand Up @@ -62,9 +63,10 @@ export const createADAction = ({
const vis = (embeddable as VisualizeEmbeddable).vis;
return Boolean(
embeddable.parent &&
embeddable.getInput()?.viewMode === 'view' &&
isDashboard(embeddable.parent) &&
vis !== undefined &&
isEligibleForVisLayers(vis)
isEligibleForVisLayers(vis, getUISettings())
);
},
execute: async ({ embeddable }: ActionContext) => {
Expand Down
8 changes: 7 additions & 1 deletion ...ponents/FeatureAnywhereContextMenu/AssociatedDetectors/containers/AssociatedDetectors.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,13 @@ function AssociatedDetectors({ embeddable, closeFlyout, setMode }) {
};
return (
<div className="associated-detectors">
<EuiFlyout style={{ maxWidth: '740px' }} ownFocus size="m" paddingSize="m" onClose={closeFlyout}>
<EuiFlyout
style={{ maxWidth: '740px' }}
ownFocus
size="m"
paddingSize="m"
onClose={closeFlyout}
>
<EuiFlyoutHeader hasBorder>
<EuiTitle>
<h2 id="associated-detectors__title">
Expand Down
6 changes: 1 addition & 5 deletions public/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,7 @@ export class AnomalyDetectionOpenSearchDashboardsPlugin
},
});

// // set embeddable plugin for feature anywhere create flyout
// setEmbeddable(embeddable);

// // set vis argumenter loader for feature anywhere associated flyout
// setSavedFeatureAnywhereLoader(visAugmenter.savedAugmentVisLoader);
setUISettings(core.uiSettings);

// Set the HTTP client so it can be pulled into expression fns to make
// direct server-side calls
Expand Down