Skip to content

Updating the CODEOWNERS file#474

Closed
bbarani wants to merge 1 commit intoopensearch-project:mainfrom
bbarani:main
Closed

Updating the CODEOWNERS file#474
bbarani wants to merge 1 commit intoopensearch-project:mainfrom
bbarani:main

Conversation

@bbarani
Copy link
Copy Markdown
Member

@bbarani bbarani commented May 5, 2023

Description

Updating the CODEOWNERS file to reflect maintainers list

Issues Resolved

Closes #421

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: bbarani <bbarani@amazon.com>
@bbarani bbarani requested a review from a team May 5, 2023 23:11
@opensearch-trigger-bot opensearch-trigger-bot bot added backport 2.x github actions Updating or adding GitHub actions labels May 5, 2023
@bbarani
Copy link
Copy Markdown
Member Author

bbarani commented May 5, 2023

Couldn't find user @yizheliu-amazon listed on the maintainers.md file. @ohltyler @ylwu-amzn Please confirm if we need to add that user. CODEOWNERS file is not green yet due to this issue.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #474 (3ea7342) into main (f0e3016) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #474   +/-   ##
=======================================
  Coverage   51.98%   51.98%           
=======================================
  Files         149      149           
  Lines        5030     5030           
  Branches      983      967   -16     
=======================================
  Hits         2615     2615           
  Misses       2156     2156           
  Partials      259      259           

@ohltyler
Copy link
Copy Markdown
Member

ohltyler commented May 8, 2023

Couldn't find user @yizheliu-amazon listed on the maintainers.md file. @ohltyler @ylwu-amzn Please confirm if we need to add that user. CODEOWNERS file is not green yet due to this issue.

We don't need to add that user - you can remove. thanks!

@ohltyler
Copy link
Copy Markdown
Member

ohltyler commented May 8, 2023

Actually - looks like this is covered in #476. I will close. @bbarani reopen if needed, thanks.

@ohltyler ohltyler closed this May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x github actions Updating or adding GitHub actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions

3 participants