[ForDemoPurpose] Feature anywhere creation flow and association flow#464
Merged
jackiehanyang merged 21 commits intoopensearch-project:featureAnywhereTempfrom May 3, 2023
jackiehanyang:featureAnywhere
Merged
[ForDemoPurpose] Feature anywhere creation flow and association flow#464jackiehanyang merged 21 commits intoopensearch-project:featureAnywhereTempfrom jackiehanyang:featureAnywhere
jackiehanyang merged 21 commits intoopensearch-project:featureAnywhereTempfrom
jackiehanyang:featureAnywhere
Conversation
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Anywhere demo
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
* run prettier command against all files Signed-off-by: Jackie Han <jkhanjob@gmail.com> * register ad as dashboard option Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add create detector page ui Signed-off-by: Jackie Han <jkhanjob@gmail.com> --------- Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <hnyng@amazon.com>
Member
|
Can you add that this is for a demo/integration purpose only. Organized reviewed PRs will be to a different branch |
jackiehanyang
changed the title
Member
|
Can you run prettier here and see if we can get unit tests to pass even though its a demo branch. Let me know if getting unit tests to pass will take to much time for this demo branch |
Member
|
Still not sure, what's the purpose of creating / pushing to a demo branch in our main repo? Typically these test/experimental branches can be left in forked repos if needed for others to pull / integrate with other changes, so we don't add confusing branches within the main repo. |
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
amitgalitz
approved these changes
May 3, 2023
ohltyler
approved these changes
May 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pr is pure for demo and integration purpose, it includes:
Organized reviewed PRs will be opened against featureAnywhere branch
Issues Resolved
[List any issues this PR will resolve]
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.