Skip to content

[Backport 2.19] Preserve user when stashing thread context when sending alert notification messages. #2027 - #2030

Merged
AWSHurneyt merged 5 commits into
opensearch-project:2.19from
AWSHurneyt:2.19-pr2027-backport
Mar 3, 2026
Merged

[Backport 2.19] Preserve user when stashing thread context when sending alert notification messages. #2027#2030
AWSHurneyt merged 5 commits into
opensearch-project:2.19from
AWSHurneyt:2.19-pr2027-backport

Conversation

@AWSHurneyt

Copy link
Copy Markdown
Collaborator

Description

Manual backport of PR #2027

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AWSHurneyt

Copy link
Copy Markdown
Collaborator Author

The Security Test Workflow / Build and test Alerting workflows are failing because the security plugin is failing to initialize which is preventing the cluster from starting. This issue isn't related to the changes in this PR.
https://github.com/opensearch-project/alerting/actions/runs/22608902503/job/65507079411?pr=2030#step:7:125

][o.o.s.OpenSearchSecurityPlugin] [b3168d08a704] OpenSearch Config path is /usr/share/opensearch/config
Error: 3-03T04:56:12,213][ERROR][o.o.b.OpenSearchUncaughtExceptionHandler] [b3168d08a704] uncaught exception in thread [main]
org.opensearch.bootstrap.StartupException: java.lang.IllegalStateException: failed to load plugin class [org.opensearch.security.OpenSearchSecurityPlugin]
	at org.opensearch.bootstrap.OpenSearch.init(OpenSearch.java:185)
	at org.opensearch.bootstrap.OpenSearch.execute(OpenSearch.java:172)
	at org.opensearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:104)
	at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138)
	at org.opensearch.cli.Command.main(Command.java:101)
	at org.opensearch.bootstrap.OpenSearch.main(OpenSearch.java:138)
	at org.opensearch.bootstrap.OpenSearch.main(OpenSearch.java:104)
Caused by: java.lang.IllegalStateException: failed to load plugin class [org.opensearch.security.OpenSearchSecurityPlugin]
	at org.opensearch.plugins.PluginsService.loadPlugin(PluginsService.java:818)
	at org.opensearch.plugins.PluginsService.loadBundle(PluginsService.java:757)
	at org.opensearch.plugins.PluginsService.loadBundles(PluginsService.java:551)
	at org.opensearch.plugins.PluginsService.<init>(PluginsService.java:197)
	at org.opensearch.node.Node.<init>(Node.java:524)
	at org.opensearch.node.Node.<init>(Node.java:451)
	at org.opensearch.bootstrap.Bootstrap$5.<init>(Bootstrap.java:242)
	at org.opensearch.bootstrap.Bootstrap.setup(Bootstrap.java:242)
	at org.opensearch.bootstrap.Bootstrap.init(Bootstrap.java:404)
	at org.opensearch.bootstrap.OpenSearch.init(OpenSearch.java:181)
	... 6 more
Caused by: java.lang.reflect.InvocationTargetException
	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:74)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
	at org.opensearch.plugins.PluginsService.loadPlugin(PluginsService.java:809)
	... 15 more
Caused by: java.util.ServiceConfigurationError: java.util.spi.CalendarDataProvider: Provider org.opensearch.common.time.IsoCalendarDataProvider could not be instantiated
	at java.base/java.util.ServiceLoader.fail(ServiceLoader.java:586)
	at java.base/java.util.ServiceLoader$ProviderImpl.newInstance(ServiceLoader.java:813)
	at java.base/java.util.ServiceLoader$ProviderImpl.get(ServiceLoader.java:729)
	at java.base/java.util.ServiceLoader$3.next(ServiceLoader.java:1403)
	at java.base/sun.util.locale.provider.SPILocaleProviderAdapter$1.run(SPILocaleProviderAdapter.java:83)
	at java.base/sun.util.locale.provider.SPILocaleProviderAdapter$1.run(SPILocaleProviderAdapter.java:76)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:571)
	at java.base/sun.util.locale.provider.SPILocaleProviderAdapter.findInstalledProvider(SPILocaleProviderAdapter.java:76)
	at java.base/sun.util.locale.provider.AuxLocaleProviderAdapter.getLocaleServiceProvider(AuxLocaleProviderAdapter.java:73)
	at java.base/sun.util.locale.provider.LocaleServiceProviderPool.findProviders(LocaleServiceProviderPool.java:313)
	at java.base/sun.util.locale.provider.LocaleServiceProviderPool.getLocalizedObjectImpl(LocaleServiceProviderPool.java:283)
	at java.base/sun.util.locale.provider.LocaleServiceProviderPool.getLocalizedObject(LocaleServiceProviderPool.java:265)
	at java.base/sun.util.locale.provider.CalendarDataUtility.retrieveFirstDayOfWeek(CalendarDataUtility.java:76)
	at java.base/java.util.Calendar.setWeekCountData(Calendar.java:3413)
	at java.base/java.util.Calendar.<init>(Calendar.java:1612)
	at java.base/java.util.GregorianCalendar.<init>(GregorianCalendar.java:741)
	at java.base/java.util.Calendar$Builder.build(Calendar.java:1497)
	at java.base/sun.util.locale.provider.CalendarProviderImpl.getInstance(CalendarProviderImpl.java:87)
	at java.base/java.util.Calendar.createCalendar(Calendar.java:1700)
	at java.base/java.util.Calendar.getInstance(Calendar.java:1663)
	at java.base/java.text.SimpleDateFormat.initializeCalendar(SimpleDateFormat.java:680)
	at java.base/java.text.SimpleDateFormat.<init>(SimpleDateFormat.java:624)
	at com.fasterxml.jackson.databind.util.StdDateFormat.<clinit>(StdDateFormat.java:116)
	at com.fasterxml.jackson.databind.ObjectMapper.<clinit>(ObjectMapper.java:411)
	at org.opensearch.security.DefaultObjectMapper.<clinit>(DefaultObjectMapper.java:81)
	at org.opensearch.security.ssl.OpenSearchSecuritySSLPlugin.<init>(OpenSearchSecuritySSLPlugin.java:227)
	at org.opensearch.security.OpenSearchSecurityPlugin.<init>(OpenSearchSecurityPlugin.java:326)
	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	... 18 more
Caused by: java.security.AccessControlException: access denied ("java.lang.RuntimePermission" "localeServiceProvider")
	at java.base/java.security.AccessControlContext.checkPermission(AccessControlContext.java:488)
	at java.base/java.security.AccessController.checkPermission(AccessController.java:1071)
	at java.base/java.lang.SecurityManager.checkPermission(SecurityManager.java:411)
	at java.base/java.util.spi.LocaleServiceProvider.checkPermission(LocaleServiceProvider.java:161)
	at java.base/java.util.spi.LocaleServiceProvider.<init>(LocaleServiceProvider.java:175)
	at java.base/java.util.spi.CalendarDataProvider.<init>(CalendarDataProvider.java:45)
	at org.opensearch.common.time.IsoCalendarDataProvider.<init>(IsoCalendarDataProvider.java:47)
	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
	at java.base/java.util.ServiceLoader$ProviderImpl$2.run(ServiceLoader.java:797)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:714)
	at java.base/java.util.ServiceLoader$ProviderImpl.newInstance(ServiceLoader.java:802)
	... 44 more
Error: Process completed with exit code 1.

…opensearch-project#2027)

Signed-off-by: Thomas Hurney <hurneyt@amazon.com>

(cherry picked from commit 528dcab)
Signed-off-by: Thomas Hurney <hurneyt@amazon.com>
Signed-off-by: Thomas Hurney <hurneyt@amazon.com>
Signed-off-by: Thomas Hurney <hurneyt@amazon.com>
This reverts commit a3aabf78b5033a618195ae682745ad88164f6686.

Signed-off-by: Thomas Hurney <hurneyt@amazon.com>
This reverts commit 84354de362b8276a0a349f25de13259b97381c82.

Signed-off-by: Thomas Hurney <hurneyt@amazon.com>
@AWSHurneyt
AWSHurneyt force-pushed the 2.19-pr2027-backport branch from a2e7c7e to 0f3f59e Compare March 3, 2026 05:10
@AWSHurneyt
AWSHurneyt marked this pull request as ready for review March 3, 2026 16:52
@AWSHurneyt
AWSHurneyt merged commit 7ba5be5 into opensearch-project:2.19 Mar 3, 2026
19 of 28 checks passed
@AWSHurneyt AWSHurneyt mentioned this pull request Mar 4, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants