[Backport 2.19] PPL Alerting: Execute Monitor and Monitor Stats (#1960) - #1988
Merged
Conversation
toepkerd
force-pushed
the
backport-2.19
branch
3 times, most recently
from
November 15, 2025 19:31
2acddf7 to
a6778d0
Compare
) * PPL Alerting initial commit Signed-off-by: Dennis Toepker <toepkerd@amazon.com> * removing unused get alerts params and adding serde tests for alertsv2 request and response Signed-off-by: Dennis Toepker <toepkerd@amazon.com> * adding get alerts rbac IT Signed-off-by: Dennis Toepker <toepkerd@amazon.com> * misc changes Signed-off-by: Dennis Toepker <toepkerd@amazon.com> * removing actioned upon TODO Signed-off-by: Dennis Toepker <toepkerd@amazon.com> * adding execute monitor request/response serde tests that are currently failing Signed-off-by: Dennis Toepker <toepkerd@amazon.com> * adding request response serde tests and passing in explicit readers and writers for PPLSQLMonitorRunResult serde Signed-off-by: Dennis Toepker <toepkerd@amazon.com> * finishing out request/response serde tests Signed-off-by: Dennis Toepker <toepkerd@amazon.com> * minor changes in tests Signed-off-by: Dennis Toepker <toepkerd@amazon.com> * adding debug logs for playground Signed-off-by: Dennis Toepker <toepkerd@amazon.com> * adding expires null check in alert expiration Signed-off-by: Dennis Toepker <toepkerd@amazon.com> * removing null check as expires duration should never be null Signed-off-by: Dennis Toepker <toepkerd@amazon.com> * cleanup Signed-off-by: Dennis Toepker <toepkerd@amazon.com> * updating timestamp field check to include any date type that includes the string date Signed-off-by: Dennis Toepker <toepkerd@amazon.com> * addressing PR comments Signed-off-by: Dennis Toepker <toepkerd@amazon.com> * misc logs changes Signed-off-by: Dennis Toepker <toepkerd@amazon.com> * changing default max query results to 1000 and replacing get alerts filters with constants Signed-off-by: Dennis Toepker <toepkerd@amazon.com> * putting query index parsing logic in try catch Signed-off-by: Dennis Toepker <toepkerd@amazon.com> * adding backtick trimming when reading index names in ppl query Signed-off-by: Dennis Toepker <toepkerd@amazon.com> * adding time measurements and logs Signed-off-by: Dennis Toepker <toepkerd@amazon.com> * refactoring PPL query execution call to use transport service with timeout instead of client Signed-off-by: Dennis Toepker <toepkerd@amazon.com> * adding monitor run timeout test Signed-off-by: Dennis Toepker <toepkerd@amazon.com> * removing return in timeout catch block to allow for monitors to get updated with last triggered times Signed-off-by: Dennis Toepker <toepkerd@amazon.com> * addressing pr comments Signed-off-by: Dennis Toepker <toepkerd@amazon.com> * addressing pr comments Signed-off-by: Dennis Toepker <toepkerd@amazon.com> * update monitor now ignores seqNo and primaryTerm, and eliminating monitor stats v2 api in favor of version parameter in existing monitor stats api Signed-off-by: Dennis Toepker <toepkerd@amazon.com> * adding experimental tags Signed-off-by: Dennis Toepker <toepkerd@amazon.com> --------- Signed-off-by: Dennis Toepker <toepkerd@amazon.com> Co-authored-by: Dennis Toepker <toepkerd@amazon.com>
toepkerd
force-pushed
the
backport-2.19
branch
from
November 15, 2025 21:59
a6778d0 to
5c50626
Compare
toepkerd
marked this pull request as ready for review
November 16, 2025 06:26
AWSHurneyt
approved these changes
Nov 16, 2025
lezzago
approved these changes
Nov 17, 2025
AWSHurneyt
added a commit
to AWSHurneyt/OpenSearch-Alerting
that referenced
this pull request
Feb 12, 2026
…roject#1960) (opensearch-project#1988)" This reverts commit 90dddfb. Signed-off-by: Thomas Hurney <hurneyt@amazon.com>
AWSHurneyt
added a commit
that referenced
this pull request
Feb 16, 2026
* Revert "PPL Alerting: Execute Monitor and Monitor Stats (#1960) (#1988)" This reverts commit 90dddfb. Signed-off-by: Thomas Hurney <hurneyt@amazon.com> * Revert "PPL Alerting: Get Alerts and Alert Lifecycle (#1972) (#1985)" This reverts commit 0677625. Signed-off-by: Thomas Hurney <hurneyt@amazon.com> * Revert "PPL Alerting: Delete Monitor, More V1/V2 Separation (#1968) (#1984)" This reverts commit 154fcb2. Signed-off-by: Thomas Hurney <hurneyt@amazon.com> * Revert "PPL Alerting: Get and Search Monitors (#1966) (#1983)" This reverts commit 852eeee. Signed-off-by: Thomas Hurney <hurneyt@amazon.com> * Revert "PPL Alerting: Create and Update Monitor V2 (#1961) (#1982)" This reverts commit f7b9b50. Signed-off-by: Thomas Hurney <hurneyt@amazon.com> * Revert "PPL Alerting: Models (#1955) (#1981)" This reverts commit 844954a. Signed-off-by: Thomas Hurney <hurneyt@amazon.com> --------- Signed-off-by: Thomas Hurney <hurneyt@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport 74aed08 from #1960