-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More javadocs #9974
Closed
Closed
More javadocs #9974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laurent Laborde <[email protected]>
Signed-off-by: Laurent Laborde <[email protected]>
Signed-off-by: Laurent Laborde <[email protected]>
Signed-off-by: Laurent Laborde <[email protected]>
Signed-off-by: Laurent Laborde <[email protected]>
Signed-off-by: Laurent Laborde <[email protected]>
Signed-off-by: Laurent Laborde <[email protected]>
Signed-off-by: Laurent Laborde <[email protected]>
Signed-off-by: Laurent Laborde <[email protected]>
Signed-off-by: Laurent Laborde <[email protected]>
ker2x
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
peternied and
Rishikesh1159
as code owners
September 11, 2023 14:47
ker2x
requested review from
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah,
dbwiddis,
sachinpkale,
sohami and
msfroh
as code owners
September 11, 2023 14:47
Compatibility status:Checks if related components are compatible with change 9eda6a9 Incompatible componentsSkipped componentsCompatible components |
i switched laptop and forgot the signoff on some commits 😢 |
Gradle Check (Jenkins) Run Completed with:
|
I think you could rebase with |
i close this PR and try to fix this with a squash/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Friendly greetings !
i wrote more javadoc and fixed some mistake from the previous PR.
I ran gradle precommit and check
There are some errors unrelated to my commits
meta ticket #221
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.