Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More javadocs #9974

Closed
wants to merge 15 commits into from
Closed

More javadocs #9974

wants to merge 15 commits into from

Conversation

ker2x
Copy link
Contributor

@ker2x ker2x commented Sep 11, 2023

Friendly greetings !

i wrote more javadoc and fixed some mistake from the previous PR.
I ran gradle precommit and check

There are some errors unrelated to my commits

meta ticket #221

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 9eda6a9

Incompatible components

Skipped components

Compatible components

@ker2x
Copy link
Contributor Author

ker2x commented Sep 11, 2023

i switched laptop and forgot the signoff on some commits 😢

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Collaborator

reta commented Sep 11, 2023

i switched laptop and forgot the signoff on some commits 😢

I think you could rebase with --signoff (or rebase + squash with --signoff)

@ker2x
Copy link
Contributor Author

ker2x commented Sep 11, 2023

i close this PR and try to fix this with a squash/merge

@ker2x ker2x closed this Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants