-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crypto Metadata support in repo registration #9802
Conversation
Signed-off-by: Gaurav Bafna <[email protected]>
Compatibility status:Checks if related components are compatible with change 975ede2 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/neural-search.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added few comments.
server/src/main/java/org/opensearch/node/remotestore/RemoteStoreNodeAttribute.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/node/remotestore/RemoteStoreNodeAttribute.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/node/remotestore/RemoteStoreNodeAttribute.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/node/remotestore/RemoteStoreNodeAttribute.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/node/remotestore/RemoteStoreNodeAttribute.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/node/remotestore/RemoteStoreNodeAttribute.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/cluster/metadata/CryptoMetadata.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/opensearch/node/RemoteStoreNodeAttributeTests.java
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
Compatibility status:Checks if related components are compatible with change 64bd991 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/cross-cluster-replication.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git] |
Gradle Check (Jenkins) Run Completed with:
|
LGTM! |
Failing tests :
|
#9807 - Flaky test - testPrimaryRelocationWhileIndexing |
Signed-off-by: Gaurav Bafna <[email protected]> (cherry picked from commit 742267d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 742267d) Signed-off-by: Gaurav Bafna <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Gaurav Bafna <[email protected]> (cherry picked from commit 742267d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 742267d) Signed-off-by: Gaurav Bafna <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Gaurav Bafna <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Gaurav Bafna <[email protected]> Signed-off-by: Ivan Brusic <[email protected]>
Signed-off-by: Gaurav Bafna <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
Crypto Metadata support in repo registration
Sample repo details
Related Issues
Partially Resolves #8623
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.