[Backport 2.x] Removing the vec file extension from INDEX_STORE_HYBRID_NIO_EXTENSIONS, to ensure the no performance degradation for vector search via Lucene Engine. by opensearch-trigger-bot[bot] · Pull Request #9540 · opensearch-project/OpenSearch

opensearch-trigger-bot · 2023-08-24T19:02:51Z

Backport a4024e7 from #9528.

github-actions · 2023-08-24T19:28:49Z

Compatibility status:

Checks if related components are compatible with change 5de4efe

Incompatible components

Incompatible components: [https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git]

github-actions · 2023-08-24T21:04:48Z

Gradle Check (Jenkins) Run Completed with:

RESULT: TIMEOUT ❌
URL: https://build.ci.opensearch.org/job/gradle-check/23426/
CommitID: 5de4efe
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-08-25T03:41:06Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testReadBlobWithRetries

URL: https://build.ci.opensearch.org/job/gradle-check/23439/
CommitID: 5de4efe
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

codecov · 2023-08-25T03:42:54Z

Codecov Report

Merging #9540 (8036df3) into 2.x (b3b1091) will increase coverage by 0.55%.
Report is 4 commits behind head on 2.x.
The diff coverage is 84.29%.

@@             Coverage Diff              @@
##                2.x    #9540      +/-   ##
============================================
+ Coverage     70.78%   71.34%   +0.55%     
- Complexity    58006    58431     +425     
============================================
  Files          4802     4805       +3     
  Lines        274034   274423     +389     
  Branches      40315    40337      +22     
============================================
+ Hits         193984   195795    +1811     
+ Misses        63435    62241    -1194     
+ Partials      16615    16387     -228

Files Changed	Coverage Δ
...testore/stats/TransportRemoteStoreStatsAction.java	`41.02% <0.00%> (-3.42%)`	⬇️
...rc/main/java/org/opensearch/index/IndexModule.java	`82.35% <ø> (ø)`
...arch/index/remote/RemoteStorePressureSettings.java	`87.09% <ø> (ø)`
...ain/java/org/opensearch/indices/IndicesModule.java	`98.23% <ø> (-0.02%)`	⬇️
...in/java/org/opensearch/index/shard/IndexShard.java	`68.53% <25.00%> (-0.55%)`	⬇️
...main/java/org/opensearch/search/SearchService.java	`72.69% <60.00%> (+0.10%)`	⬆️
...in/java/org/opensearch/index/ReplicationStats.java	`77.41% <77.41%> (ø)`
...ch/index/remote/RemoteTranslogTransferTracker.java	`78.91% <78.91%> (ø)`
...search/index/shard/RemoteStoreRefreshListener.java	`86.26% <80.00%> (-1.65%)`	⬇️
...rg/opensearch/index/translog/RemoteFsTranslog.java	`71.57% <86.20%> (+0.37%)`	⬆️
... and 14 more

... and 449 files with indirect coverage changes

navneet1v · 2023-08-25T16:48:12Z

@msfroh can we merge this change now, is there something which is missing from my side?

msfroh · 2023-08-25T21:22:30Z

Huh... for some reason I can't merge. I'm not in the list of code owner reviewers for this one.

navneet1v · 2023-08-25T21:23:57Z

Huh... for some reason I can't merge. I'm not in the list of code owner reviewers for this one.

may be the maintainers list is not backported :P @andrross I remember you added @msfroh in the maintainers list. :P

github-actions · 2023-08-28T22:33:09Z

Compatibility status:

Checks if related components are compatible with change d607161

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git]

github-actions · 2023-08-28T22:45:36Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/23660/
CommitID: d607161
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-08-29T16:29:26Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/23733/
CommitID: 2b23e02
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-08-29T16:32:34Z

Compatibility status:

Checks if related components are compatible with change 2b23e02

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security-analytics.git]

github-actions · 2023-08-29T21:52:47Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/23756/
CommitID: 2b23e02
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-08-31T08:07:15Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/23933/
CommitID: 2b23e02
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-09-01T21:52:11Z

Compatibility status:

Checks if related components are compatible with change 4cc4cb4

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

github-actions · 2023-09-01T22:10:18Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/24176/
CommitID: 4cc4cb4
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-09-01T23:28:20Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/24187/
CommitID: 4cc4cb4
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

…S, to ensure the no performance degradation for vector search via Lucene Engine. (#9528) Signed-off-by: Navneet Verma <navneev@amazon.com> (cherry picked from commit a4024e7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

github-actions · 2023-09-05T16:14:33Z

Compatibility status:

Checks if related components are compatible with change 8036df3

Incompatible components

Incompatible components: [https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

github-actions · 2023-09-05T17:54:22Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testReadRangeBlobWithRetries

URL: https://build.ci.opensearch.org/job/gradle-check/24479/
CommitID: 8036df3
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

msfroh approved these changes Aug 25, 2023

View reviewed changes

kkmr approved these changes Aug 27, 2023

View reviewed changes

andrross force-pushed the backport/backport-9528-to-2.x branch from 5de4efe to d607161 Compare August 28, 2023 22:04

andrross force-pushed the backport/backport-9528-to-2.x branch from d607161 to 2b23e02 Compare August 29, 2023 16:00

andrross force-pushed the backport/backport-9528-to-2.x branch from 2b23e02 to 4cc4cb4 Compare September 1, 2023 21:20

andrross force-pushed the backport/backport-9528-to-2.x branch from 4cc4cb4 to 8036df3 Compare September 5, 2023 15:47

andrross merged commit 7cab38a into 2.x Sep 5, 2023

andrross deleted the backport/backport-9528-to-2.x branch September 5, 2023 23:14

Uh oh!

Conversation

opensearch-trigger-bot Bot commented Aug 24, 2023

Uh oh!

github-actions Bot commented Aug 24, 2023

Compatibility status:

Incompatible components

Skipped components

Compatible components

Uh oh!

github-actions Bot commented Aug 24, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions Bot commented Aug 25, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

codecov Bot commented Aug 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

navneet1v commented Aug 25, 2023

Uh oh!

msfroh commented Aug 25, 2023

Uh oh!

navneet1v commented Aug 25, 2023

Uh oh!

github-actions Bot commented Aug 28, 2023

Compatibility status:

Incompatible components

Skipped components

Compatible components

Uh oh!

github-actions Bot commented Aug 28, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions Bot commented Aug 29, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions Bot commented Aug 29, 2023

Compatibility status:

Incompatible components

Skipped components

Compatible components

Uh oh!

github-actions Bot commented Aug 29, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions Bot commented Aug 31, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions Bot commented Sep 1, 2023

Compatibility status:

Incompatible components

Skipped components

Compatible components

Uh oh!

github-actions Bot commented Sep 1, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions Bot commented Sep 1, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions Bot commented Sep 5, 2023

Compatibility status:

Incompatible components

Skipped components

Compatible components

Uh oh!

github-actions Bot commented Sep 5, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Aug 25, 2023 •

edited

Loading