Return 409 Conflict HTTP status instead of 503 on failure to concurre…

[baba-devv]

Signed-off-by: Mani [email protected]

Return 409 Conflict HTTP status instead of 500 on failure to concurrently execute snapshots

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/21348/
• CommitID: e6451d6

[codecov]

Codecov Report

Merging #8986 (7a8057f) into main (8cecd5a) will increase coverage by 0.07%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #8986      +/-   ##
============================================
+ Coverage     71.10%   71.17%   +0.07%     
- Complexity    57415    57474      +59     
============================================
  Files          4775     4775              
  Lines        270700   270700              
  Branches      39566    39566              
============================================
+ Hits         192483   192680     +197     
+ Misses        62066    61878     -188     
+ Partials      16151    16142       -9     

Files Changed	Coverage Δ
...src/main/java/org/opensearch/ExceptionsHelper.java	82.71% <ø> (ø)
.../main/java/org/opensearch/OpenSearchException.java	91.11% <ø> (ø)
...rch/core/action/ShardOperationFailedException.java	100.00% <ø> (ø)
.../support/DefaultShardOperationFailedException.java	95.65% <ø> (ø)
...a/org/opensearch/core/common/ParsingException.java	96.66% <ø> (ø)
.../core/common/breaker/CircuitBreakingException.java	100.00% <ø> (ø)
.../opensearch/core/common/io/stream/StreamInput.java	88.84% <ø> (+1.17%)	⬆️
...opensearch/core/common/io/stream/StreamOutput.java	95.18% <ø> (+0.64%)	⬆️
...src/main/java/org/opensearch/core/index/Index.java	100.00% <ø> (ø)
.../java/org/opensearch/core/index/shard/ShardId.java	97.56% <ø> (ø)
... and 39 more

... and 436 files with indirect coverage changes

[baba-devv]

@dblock Can you check this PR, its replacement for #5855 ?

[saratvemulapalli]

Thanks for the change and adding a test.
Seems like a reasonable change to me!

Do we have to update docs and clients for precise error handling?

[reta]

Do we have to update docs and clients for precise error handling?

The change for public API status code could be considered a breaking change (unless this is a indeed the bug), the documentation definitely needs an update.

[dblock]

Do we have to update docs and clients for precise error handling?

The change for public API status code could be considered a breaking change (unless this is a indeed the bug), the documentation definitely needs an update.

Yep, we are only considering this for main.

[baba-devv]

@dblock what should my next steps be for this ?

[opensearch-trigger-bot]

Compatibility status:

> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/security-analytics.git]
Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

BUILD SUCCESSFUL in 27m 28s

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

• URL: https://build.ci.opensearch.org/job/gradle-check/21818/
• CommitID: 06b7e85
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[dblock]

@dblock what should my next steps be for this ?

Will merge as soon as I have a green build.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/22336/
• CommitID: 89ce8f1
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/22356/
• CommitID: 89ce8f1

[opensearch-trigger-bot]

Compatibility status:

> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git]
Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

BUILD SUCCESSFUL in 37m 59s

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDropPrimaryDuringReplication

• URL: https://build.ci.opensearch.org/job/gradle-check/22687/
• CommitID: 7a8057f
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.