-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[Remote Store] Add metadata prefix to Remote Translog Metadata file #8914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Gradle Check (Jenkins) Run Completed with:
|
sachinpkale
reviewed
Jul 27, 2023
server/src/main/java/org/opensearch/index/translog/transfer/TranslogTransferMetadata.java
Show resolved
Hide resolved
sachinpkale
approved these changes
Jul 27, 2023
linuxpi
reviewed
Jul 27, 2023
server/src/test/java/org/opensearch/index/translog/transfer/TranslogTransferManagerTests.java
Show resolved
Hide resolved
Contributor
|
LGTM. 1 minor comment |
linuxpi
approved these changes
Jul 27, 2023
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Author
I am getting gradle failures despite retries. All the tests are passing . Looks like there is some issue with jenkins . |
Contributor
|
seeing similar failure here - #8812 |
Signed-off-by: Gaurav Bafna <[email protected]>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Author
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8914 +/- ##
=========================================
Coverage 71.12% 71.12%
- Complexity 57212 57256 +44
=========================================
Files 4759 4759
Lines 269881 269881
Branches 39488 39488
=========================================
+ Hits 191943 191948 +5
- Misses 61752 61754 +2
+ Partials 16186 16179 -7
|
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 28, 2023
Signed-off-by: Gaurav Bafna <[email protected]> (cherry picked from commit 96630f0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna
pushed a commit
that referenced
this pull request
Jul 28, 2023
(cherry picked from commit 96630f0) Signed-off-by: Gaurav Bafna <[email protected]>
baba-devv
pushed a commit
to baba-devv/OpenSearch
that referenced
this pull request
Jul 28, 2023
…ect#8914) Signed-off-by: Gaurav Bafna <[email protected]>
baba-devv
pushed a commit
to baba-devv/OpenSearch
that referenced
this pull request
Jul 29, 2023
…ect#8914) Signed-off-by: Gaurav Bafna <[email protected]>
kaushalmahi12
pushed a commit
to kaushalmahi12/OpenSearch
that referenced
this pull request
Sep 12, 2023
…ect#8914) Signed-off-by: Gaurav Bafna <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]>
brusic
pushed a commit
to brusic/OpenSearch
that referenced
this pull request
Sep 25, 2023
…ect#8914) Signed-off-by: Gaurav Bafna <[email protected]> Signed-off-by: Ivan Brusic <[email protected]>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…ect#8914) Signed-off-by: Gaurav Bafna <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
metadataprefix to remote translog metadata files. This serves two purposeRelated Issues
#8834
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.