[Backport 2.x] Fix SegmentReplicationUsingRemoteStoreIT.testReplicaHasDiffFilesThanPrimary. #8890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opensearch-trigger-bot
bot
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
reta,
ryanbogan,
sachinpkale,
saratvemulapalli,
setiah,
shwetathareja,
sohami and
tlfeng
as code owners
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Member
|
dreamer-89
approved these changes
Jul 26, 2023
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
|
There's a failure that was previously closed out - timeout issue: org.opensearch.indices.replication.SegmentReplicationRelocationIT.testNewlyAddedReplicaIsUpdated |
This test is failing in two ways. First it fails when copying segments from the remote store and there is a cksum mismatch. In this case it is not guaranteed the directory implementation will replace the existing file when copying from the store. This change ensures the mismatched file is cleaned up but only if the shard is not serving reads. In that case we fail the shard so it is re-recovered rather than deleting the segment underneath it. This test also fails with a divide by 0 in RemoteStoreRefreshListener. Signed-off-by: Marc Handalian <[email protected]> (cherry picked from commit e1a4125) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mch2
force-pushed
the
backport/backport-8863-to-2.x
branch
from
2de97cc to
4b3d61d
Compare
Member
|
Pushed a rebase here. |
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport e1a4125 from #8863.