[Backport 2.x] [Refactor] StreamIO from common to core.common namespace in core lib (#8157)#8782
Merged
andrross merged 2 commits intoopensearch-project:2.xfrom Jul 19, 2023
Conversation
…pensearch-project#8157) * [Refactor] StreamIO from common to core.common in core lib This PR is a mechanical refactor of all Stream classes in o.o.common.io.stream to o.o.core.common.io.stream namespace. In addition to the namespace refactor several loose end classes in o.o.common.io.stream of the :server module are refactored to o.o.core.common.io.stream of the :libs:opensearch-core library. These classes include the following: * ByteBufferStreamInpu * BytesStreamInput * DataOutputStreamOutput * FilterStreamInput * NamedWriteableAwareStreamInput * OutputStreamStreamOutput * VersionedNamedWriteable Companion tests are also refactored from the server test folder to the corresponding core test folder. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
nknize
added
enhancement
nknize
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kartg,
kotwanikunal,
mch2,
owaiskazi19,
reta,
ryanbogan,
sachinpkale,
saratvemulapalli,
setiah,
shwetathareja and
tlfeng
as code owners
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #8782 +/- ##
============================================
- Coverage 70.72% 70.69% -0.04%
- Complexity 57329 57387 +58
============================================
Files 4759 4759
Lines 271587 271577 -10
Branches 40035 40034 -1
============================================
- Hits 192080 191990 -90
- Misses 63026 63109 +83
+ Partials 16481 16478 -3
|
andrross
approved these changes
Jul 19, 2023
3 tasks
2 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport e354201 from #8157.