-
Notifications
You must be signed in to change notification settings - Fork 2.4k
[2.9] Revert "Support transport action names when registering NamedRoutes (#7957) (#8459)" #8651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
79316a4 to
0e1541e
Compare
Gradle Check (Jenkins) Run Completed with:
|
owaiskazi19
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dbwiddis another pair of eyes
dbwiddis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QQ: I see this also reverts the bump of azure-storage-blob. Is that intended?
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.9 #8651 +/- ##
============================================
- Coverage 71.05% 70.68% -0.38%
+ Complexity 57461 57182 -279
============================================
Files 4745 4746 +1
Lines 270757 270727 -30
Branches 39961 39953 -8
============================================
- Hits 192390 191365 -1025
- Misses 62154 62922 +768
- Partials 16213 16440 +227
|
0e1541e to
ebf3ebc
Compare
fixed. |
…g NamedRoutes (opensearch-project#7957) (opensearch-project#8459)" This reverts commit cd82f4c. Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
ebf3ebc to
6c0d877
Compare
Gradle Check (Jenkins) Run Completed with:
|
|
@dbwiddis this PR is based to 2.9. We can remove backport 2.x and backport 2.9 labels |
|
LGTM. Please double check that the change log entry in 2.x is handled properly and this isn't included in the 2.9 section. |
Gradle Check (Jenkins) Run Completed with:
|
|
The changelog entry is correct in 2.x, as this is present in 2.x. The entry is removed only from this branch. |
This reverts commit cd82f4c.
Reverting due to: #8652
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.