Skip to content

Conversation

@Xtansia
Copy link
Contributor

@Xtansia Xtansia commented Jul 11, 2023

Backport 0b42c2c from #8307

…earch-project#8307)

- Use log4j's PluginProcessor annotation processor for plugin discovery
- Remove usage of deprecated explicit plugin discovery
- Pass through Configuration in OpenSearchJsonLayout to work around https://issues.apache.org/jira/browse/LOG4J2-3562

Signed-off-by: Thomas <[email protected]>
Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]>
Co-authored-by: Andrew Ross <[email protected]>
(cherry picked from commit 0b42c2c)
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Thomas Farr <[email protected]>
@Xtansia Xtansia force-pushed the backport/backport-8307-to-2.x branch from 320ebf4 to 83f484b Compare July 11, 2023 21:45
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #8645 (fcd0820) into 2.x (5a0b6b0) will increase coverage by 0.54%.
The diff coverage is 77.20%.

@@             Coverage Diff              @@
##                2.x    #8645      +/-   ##
============================================
+ Coverage     70.55%   71.10%   +0.54%     
- Complexity    57090    57543     +453     
============================================
  Files          4745     4745              
  Lines        270776   270901     +125     
  Branches      39967    39974       +7     
============================================
+ Hits         191051   192623    +1572     
+ Misses        63320    62067    -1253     
+ Partials      16405    16211     -194     
Impacted Files Coverage Δ
...org/opensearch/common/logging/LogConfigurator.java 16.48% <ø> (-1.61%) ⬇️
...pensearch/common/logging/OpenSearchJsonLayout.java 0.00% <0.00%> (ø)
.../store/exception/ChecksumCombinationException.java 0.00% <ø> (ø)
...java/org/opensearch/index/translog/Checkpoint.java 72.34% <ø> (ø)
...ain/java/org/opensearch/threadpool/ThreadPool.java 84.59% <ø> (-0.30%) ⬇️
...earch/index/store/RemoteSegmentStoreDirectory.java 86.34% <64.91%> (-5.71%) ⬇️
...org/opensearch/common/io/InputStreamContainer.java 87.50% <66.66%> (ø)
...search/index/shard/RemoteStoreRefreshListener.java 83.09% <72.09%> (-0.33%) ⬇️
...ex/translog/transfer/BlobStoreTransferService.java 88.88% <86.84%> (-0.59%) ⬇️
...on/blobstore/transfer/RemoteTransferContainer.java 64.78% <100.00%> (+8.45%) ⬆️
... and 9 more

... and 471 files with indirect coverage changes

@kotwanikunal
Copy link
Member

Re-ran gradle check since it timed out.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants